From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Ortiz, Lance E" <lance.oritz@hp.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"lance_ortiz@hotmail.com" <lance_ortiz@hotmail.com>,
"jiang.liu@huawei.com" <jiang.liu@huawei.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/3] aerdrv: Enhanced AER logging
Date: Tue, 4 Dec 2012 18:31:10 -0200 [thread overview]
Message-ID: <20121204183110.3de876de@redhat.com> (raw)
In-Reply-To: <A961433CDFF2F640A2866803152E61F9516EEACD@G4W3218.americas.hpqcorp.net>
Em Tue, 4 Dec 2012 20:14:10 +0000
"Ortiz, Lance E" <lance.oritz@hp.com> escreveu:
> > > + if (!dev) {
> > > + pr_info("PCI AER Cannot get PCI device
> > %04x:%02x:%02x.%d\n",
> > > + pcie->device_id.segment, pcie->device_id.bus,
> > > + pcie->device_id.slot, pcie->device_id.function);
> >
> > Hmm... please correct if I'm wrong, but an error happened at PCI, and
> > also a
> > kernel bug that prevented it to get the proper PCI device...
> >
> > IMHO, the message here should be stronger, and likely printed via
> > pr_err().
> >
>
> Mauro,
>
> I modeled this message after other places in the kernel where this function failed. So I figured it would be safe to be consistent there. I agree though that it should be pr_err(). I can make that change.
I understand. On most cases, this may not be a critical issue.
However, in this particular case, if PCI AER got an error, but the device
is not found when trying to handle it, it can be an indication that
the PCI device has a more serious issue. So, I'm in favor of changing it,
and likely be more verbose at the error message, saying that the device
was not found while trying to report an error condition that happened
there. It could make sense to even send a trace for the daemon to be
aware of the error, on some pci device that vanished likely due to the
error.
Regards,
Mauro
next prev parent reply other threads:[~2012-12-04 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 17:04 [PATCH v6 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-12-04 17:04 ` [PATCH v6 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-12-04 18:41 ` Mauro Carvalho Chehab
2012-12-04 20:14 ` Ortiz, Lance E
2012-12-04 20:31 ` Mauro Carvalho Chehab [this message]
2012-12-04 20:36 ` Borislav Petkov
2012-12-04 17:04 ` [PATCH v6 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-12-04 17:39 ` Joe Perches
2012-12-04 20:06 ` Ortiz, Lance E
2012-12-04 18:36 ` [PATCH v6 1/3] aerdrv: Trace Event for AER Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204183110.3de876de@redhat.com \
--to=mchehab@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jiang.liu@huawei.com \
--cc=lance.oritz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).