From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428Ab2LDVn7 (ORCPT ); Tue, 4 Dec 2012 16:43:59 -0500 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:43701 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753180Ab2LDVn6 (ORCPT ); Tue, 4 Dec 2012 16:43:58 -0500 Date: Tue, 4 Dec 2012 22:43:49 +0100 From: Jean Delvare To: Benjamin Tissoires Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/14] HID: i2c-hid: fix checkpatch.pl warning Message-ID: <20121204224349.2cefa121@endymion.delvare> In-Reply-To: <1354634875-5182-5-git-send-email-benjamin.tissoires@gmail.com> References: <1354634875-5182-1-git-send-email-benjamin.tissoires@gmail.com> <1354634875-5182-5-git-send-email-benjamin.tissoires@gmail.com> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Dec 2012 16:27:45 +0100, Benjamin Tissoires wrote: > We should not initialize to 0 static declarations. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index ad771a7..9ee6555 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -46,7 +46,7 @@ > #define I2C_HID_PWR_SLEEP 0x01 > > /* debug option */ > -static bool debug = false; > +static bool debug; > module_param(debug, bool, 0444); > MODULE_PARM_DESC(debug, "print a lot of debug information"); > Reviewed-by: Jean Delvare -- Jean Delvare