From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Peter Hurley <peter@hurleysoftware.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue
Date: Wed, 5 Dec 2012 17:11:40 +0000 [thread overview]
Message-ID: <20121205171140.03b6ca06@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <50BF732C.6030306@linutronix.de>
On Wed, 05 Dec 2012 17:15:40 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 12/03/2012 06:41 PM, Peter Hurley wrote:
> > The lock logic for tty_set_ldisc() is wrong. Despite existing code in
> > tty_set_ldisc() and tty_ldisc_hangup(), the ldisc_mutex does **not**
> > (and should not) play a role in acquiring or releasing ldisc references.
> > The only thing that needs to happen here is below (don't actually use
> > below because I just hand-edited it):
>
> Hmm. What about I stay in sync with the code that is already in tree
> and if the wrong locking gets removed in both places later on?
>
> Alan, what do you prefer?
So long as it ends up right I don't care 8)
next prev parent reply other threads:[~2012-12-05 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 12:39 [PATCH] tty: don't dead while flushing workqueue Sebastian Andrzej Siewior
2012-11-21 14:04 ` Alan Cox
2012-11-27 9:53 ` Sebastian Andrzej Siewior
2012-11-27 17:22 ` Greg Kroah-Hartman
2012-11-27 18:01 ` [PATCH RESEND] tty: don't dead lock " Sebastian Andrzej Siewior
2012-11-30 17:09 ` Sebastian Andrzej Siewior
2012-11-30 17:21 ` Greg Kroah-Hartman
2012-11-30 18:11 ` Sebastian Andrzej Siewior
2012-12-03 17:41 ` Peter Hurley
2012-12-05 16:15 ` Sebastian Andrzej Siewior
2012-12-05 17:11 ` Alan Cox [this message]
2012-12-25 22:02 ` [PATCH v3] tty: don't deadlock " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205171140.03b6ca06@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).