From: Dan Williams <djbw@fb.com>
To: linux-kernel@vger.kernel.org
Cc: vinod.koul@intel.com, linux@arm.linux.org.uk, dave.jiang@intel.com
Subject: [PATCH 00/12] dmaengine_unmap_data
Date: Thu, 06 Dec 2012 01:25:08 -0800 [thread overview]
Message-ID: <20121206091055.17085.47979.stgit@dev279.prn1.facebook.com> (raw)
dmaengine from the beginning has placed the burden of unmapping dma
buffers on the individual drivers. The thought being that since the dma
driver already has the descriptor it can use that information for
unmapping. This results in a lot of cruft to read back data from
descriptors, places a burden on channels that need to break up an
operation internally into multiple descriptors, and makes it difficult
to have dma mappings with different lifetimes than the current
operation.
For example an xor->copy->xor chain wants to leave all buffers
mapped until completion, async_tx currently performs invalid overlapping
mappings. With dmaengine_unmap_data map once and take a reference for
descriptor that uses the mapping.
Thanks to Bart for getting this cleanup started!
I'll also push this out to the 'unmap' branch:
git://git.kernel.org/pub/scm/linux/kernel/git/djbw/dmaengine unmap
--
Dan
---
Bartlomiej Zolnierkiewicz (2):
dmaengine: remove DMA unmap from drivers
dmaengine: remove DMA unmap flags
Dan Williams (10):
dmaengine: consolidate memcpy apis
dmaengine: prepare for generic 'unmap' data
dmaengine: reference counted unmap data
async_memcpy: convert to dmaengine_unmap_data
async_memset: convert to dmaengine_unmap_data
async_xor: convert to dmaengine_unmap_data
async_xor_val: convert to dmaengine_unmap_data
async_raid6_recov: convert to dmaengine_unmap_data
async_pq: convert to dmaengine_unmap_data
async_pq_val: convert to dmaengine_unmap_data
arch/arm/include/asm/hardware/iop3xx-adma.h | 30 ---
arch/arm/include/asm/hardware/iop_adma.h | 4
arch/arm/mach-iop13xx/include/mach/adma.h | 26 ---
crypto/async_tx/async_memcpy.c | 36 ++--
crypto/async_tx/async_memset.c | 15 +-
crypto/async_tx/async_pq.c | 174 ++++++++++-------
crypto/async_tx/async_raid6_recov.c | 61 ++++--
crypto/async_tx/async_xor.c | 122 +++++++-----
drivers/ata/pata_arasan_cf.c | 3
drivers/dma/amba-pl08x.c | 32 ---
drivers/dma/at_hdmac.c | 26 ---
drivers/dma/dmaengine.c | 261 ++++++++++++++++++--------
drivers/dma/dmatest.c | 3
drivers/dma/dw_dmac.c | 21 --
drivers/dma/ep93xx_dma.c | 30 ---
drivers/dma/fsldma.c | 17 --
drivers/dma/ioat/dma.c | 20 --
drivers/dma/ioat/dma.h | 12 -
drivers/dma/ioat/dma_v2.c | 2
drivers/dma/ioat/dma_v3.c | 143 +-------------
drivers/dma/iop-adma.c | 99 ----------
drivers/dma/mv_xor.c | 46 -----
drivers/dma/ppc4xx/adma.c | 270 ---------------------------
drivers/dma/timb_dma.c | 37 ----
drivers/dma/txx9dmac.c | 25 ---
drivers/media/platform/m2m-deinterlace.c | 3
drivers/media/platform/timblogiw.c | 2
drivers/misc/carma/carma-fpga.c | 3
drivers/mtd/nand/atmel_nand.c | 3
drivers/mtd/nand/fsmc_nand.c | 2
drivers/net/ethernet/micrel/ks8842.c | 6 -
drivers/spi/spi-dw-mid.c | 4
include/linux/dmaengine.h | 49 ++++-
33 files changed, 481 insertions(+), 1106 deletions(-)
next reply other threads:[~2012-12-06 9:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 9:25 Dan Williams [this message]
2012-12-06 9:25 ` [PATCH 01/12] dmaengine: consolidate memcpy apis Dan Williams
2012-12-06 9:25 ` [PATCH 02/12] dmaengine: prepare for generic 'unmap' data Dan Williams
2012-12-06 15:47 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:44 ` dmaengine_unmap_data patches (was: Re: Re: [PATCH 02/12] dmaengine: prepare for generic 'unmap' data) Bartlomiej Zolnierkiewicz
2013-06-28 17:35 ` Dan Williams
2012-12-06 9:25 ` [PATCH 03/12] dmaengine: reference counted unmap data Dan Williams
2012-12-06 15:47 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:25 ` [PATCH 04/12] async_memcpy: convert to dmaengine_unmap_data Dan Williams
2012-12-06 15:47 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:25 ` [PATCH 05/12] async_memset: " Dan Williams
2012-12-06 15:48 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:25 ` [PATCH 06/12] async_xor: " Dan Williams
2012-12-06 15:48 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:25 ` [PATCH 07/12] async_xor_val: " Dan Williams
2012-12-06 15:48 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:25 ` [PATCH 08/12] async_raid6_recov: " Dan Williams
2012-12-06 15:48 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:25 ` [PATCH 09/12] async_pq: " Dan Williams
2012-12-06 15:48 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:26 ` [PATCH 10/12] async_pq_val: " Dan Williams
2012-12-06 15:48 ` Bartlomiej Zolnierkiewicz
2012-12-06 9:26 ` [PATCH 11/12] dmaengine: remove DMA unmap from drivers Dan Williams
2012-12-06 9:26 ` [PATCH 12/12] dmaengine: remove DMA unmap flags Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206091055.17085.47979.stgit@dev279.prn1.facebook.com \
--to=djbw@fb.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).