From: Joerg Roedel <joro@8bytes.org>
To: Steven Kinney <steven.kinney@amd.com>
Cc: Hiroshi DOYU <hdoyu@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Jiri Kosina <jkosina@suse.cz>, Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH 1/1] iommuv2/amd: Enable Performance Counters On Family 15h Models 10h-1Fh
Date: Thu, 6 Dec 2012 11:32:38 +0100 [thread overview]
Message-ID: <20121206103238.GF1806@8bytes.org> (raw)
In-Reply-To: <1354659546-9700-1-git-send-email-steven.kinney@amd.com>
On Tue, Dec 04, 2012 at 04:19:06PM -0600, Steven Kinney wrote:
> drivers/iommu/Kconfig | 10 +++++
> drivers/iommu/amd_iommu_init.c | 85 +++++++++++++++++++++++++++++++++++++++
> drivers/iommu/amd_iommu_types.h | 13 +++++-
> 3 files changed, 107 insertions(+), 1 deletion(-)
So first of all, this patch alone doesn't make sense. You should submit
it in a patch-set that enabled IOMMUv2 performance counters for the
end-user. This means together with the PMU implementation and tools
support.
Further I don't see how this patch is specific to Family 15h Models
10h-1Fh as described in the subject-line.
Any comments on these two points?
Cheers,
Joerg
next prev parent reply other threads:[~2012-12-06 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 22:19 [PATCH 1/1] iommuv2/amd: Enable Performance Counters On Family 15h Models 10h-1Fh Steven Kinney
2012-12-06 10:32 ` Joerg Roedel [this message]
2012-12-06 17:07 ` Kinney, Steven
-- strict thread matches above, loose matches on Subject: below --
2012-11-26 22:00 Steven Kinney
2012-12-02 13:30 ` Joerg Roedel
2012-12-02 21:55 ` Kinney, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206103238.GF1806@8bytes.org \
--to=joro@8bytes.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.kinney@amd.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).