From: Andrew Morton <akpm@linux-foundation.org>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kexec@lists.infradead.org
Subject: Re: [RFC PATCH 0/8] remove vm_struct list management
Date: Thu, 6 Dec 2012 14:45:34 -0800 [thread overview]
Message-ID: <20121206144534.23d26318.akpm@linux-foundation.org> (raw)
In-Reply-To: <1354810175-4338-1-git-send-email-js1304@gmail.com>
On Fri, 7 Dec 2012 01:09:27 +0900
Joonsoo Kim <js1304@gmail.com> wrote:
> This patchset remove vm_struct list management after initializing vmalloc.
> Adding and removing an entry to vmlist is linear time complexity, so
> it is inefficient. If we maintain this list, overall time complexity of
> adding and removing area to vmalloc space is O(N), although we use
> rbtree for finding vacant place and it's time complexity is just O(logN).
>
> And vmlist and vmlist_lock is used many places of outside of vmalloc.c.
> It is preferable that we hide this raw data structure and provide
> well-defined function for supporting them, because it makes that they
> cannot mistake when manipulating theses structure and it makes us easily
> maintain vmalloc layer.
>
> I'm not sure that "7/8: makes vmlist only for kexec" is fine.
> Because it is related to userspace program.
> As far as I know, makedumpfile use kexec's output information and it only
> need first address of vmalloc layer. So my implementation reflect this
> fact, but I'm not sure. And now, I don't fully test this patchset.
> Basic operation work well, but I don't test kexec. So I send this
> patchset with 'RFC'.
>
> Please let me know what I am missing.
>
> This series based on v3.7-rc7 and on top of submitted patchset for ARM.
> 'introduce static_vm for ARM-specific static mapped area'
> https://lkml.org/lkml/2012/11/27/356
> But, running properly on x86 without ARM patchset.
This all looks rather nice, but not mergeable into anything at this
stage in the release cycle.
What are the implications of "on top of submitted patchset for ARM"?
Does it depens on the ARM patches in any way, or it it independently
mergeable and testable?
next prev parent reply other threads:[~2012-12-06 22:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 16:09 [RFC PATCH 0/8] remove vm_struct list management Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 1/8] mm, vmalloc: change iterating a vmlist to find_vm_area() Joonsoo Kim
2012-12-07 7:44 ` Pekka Enberg
2012-12-07 8:15 ` Bob Liu
2012-12-07 13:40 ` JoonSoo Kim
2012-12-10 5:20 ` guanxuetao
2012-12-10 15:13 ` Chris Metcalf
2013-01-24 15:50 ` Ingo Molnar
2012-12-06 16:09 ` [RFC PATCH 2/8] mm, vmalloc: move get_vmalloc_info() to vmalloc.c Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 3/8] mm, vmalloc: protect va->vm by vmap_area_lock Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 4/8] mm, vmalloc: iterate vmap_area_list, instead of vmlist in vread/vwrite() Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 5/8] mm, vmalloc: iterate vmap_area_list in get_vmalloc_info() Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 6/8] mm, vmalloc: iterate vmap_area_list, instead of vmlist, in vmallocinfo() Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 7/8] mm, vmalloc: makes vmlist only for kexec Joonsoo Kim
2012-12-06 16:09 ` [RFC PATCH 8/8] mm, vmalloc: remove list management operation after initializing vmalloc Joonsoo Kim
2012-12-06 22:45 ` Andrew Morton [this message]
2012-12-07 13:05 ` [RFC PATCH 0/8] remove vm_struct list management JoonSoo Kim
2012-12-06 22:50 ` Andrew Morton
2012-12-07 13:16 ` JoonSoo Kim
2012-12-07 14:59 ` Vivek Goyal
2012-12-10 14:40 ` JoonSoo Kim
2012-12-11 14:41 ` Dave Anderson
2012-12-11 21:48 ` Vivek Goyal
2012-12-11 22:17 ` Dave Anderson
2012-12-12 5:56 ` Atsushi Kumagai
2012-12-12 14:10 ` JoonSoo Kim
2012-12-07 3:37 ` Bob Liu
2012-12-07 13:35 ` JoonSoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206144534.23d26318.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=js1304@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).