From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 4/5] perf diff: Use internal rb tree for compute resort
Date: Thu, 6 Dec 2012 17:51:36 +0100 [thread overview]
Message-ID: <20121206165136.GA27199@krava.brq.redhat.com> (raw)
In-Reply-To: <1354806581-5316-5-git-send-email-namhyung@kernel.org>
On Fri, Dec 07, 2012 at 12:09:40AM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> There's no reason to run hists_compute_resort() using output tree.
> Convert it to use internal tree so that it can remove unnecessary
> _output_resort.
I have another patch in queue ommiting dummy entries to display
number in the compute column, so we don't have confusing 'sorted'
outputs like:
[jolsa@krava perf]$ ./perf diff -c+delta
# Event 'cycles:u'
#
# Baseline Delta Shared Object Symbol
# ........ ....... ............. ..........................
#
17.92% -17.92% libc-2.15.so [.] _IO_link_in
+77.54% libc-2.15.so [.] __fprintf_chk
15.64% -15.64% libc-2.15.so [.] _dl_addr
0.08% +0.61% ld-2.15.so [.] _start
12.16% -12.16% ld-2.15.so [.] dl_main
15.39% -15.39% ld-2.15.so [.] _dl_check_map_versions
38.81% -17.04% [kernel.kallsyms] [k] page_fault
just in case anyone actualy tries and wonders ;)
We need following change as well, because output resort does
also col width recalc. Please add it if you respin, or I can
send it later.
other than that:
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
---
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index f66968e..6f56f78 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -425,12 +425,15 @@ static void hists__compute_resort(struct hists *hists)
hists->entries = RB_ROOT;
next = rb_first(root);
+ hists__reset_col_len(hists);
+
while (next != NULL) {
struct hist_entry *he;
he = rb_entry(next, struct hist_entry, rb_node_in);
next = rb_next(&he->rb_node_in);
+ hists__calc_col_len(hists, he);
insert_hist_entry_by_compute(&hists->entries, he, compute);
}
}
next prev parent reply other threads:[~2012-12-06 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 15:09 [PATCH 0/5] perf hists: Changes on hists__{match,link} (v3) Namhyung Kim
2012-12-06 15:09 ` [PATCH 1/5] perf diff: Removing displacement output option Namhyung Kim
2012-12-06 15:09 ` [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists Namhyung Kim
2012-12-06 16:53 ` Jiri Olsa
2012-12-06 19:09 ` Arnaldo Carvalho de Melo
2012-12-07 8:38 ` Namhyung Kim
2012-12-07 10:18 ` Jiri Olsa
2012-12-06 15:09 ` [PATCH 3/5] perf hists: Link hist entries before inserting to an output tree Namhyung Kim
2012-12-06 16:25 ` Jiri Olsa
2012-12-07 8:45 ` Namhyung Kim
2012-12-06 15:09 ` [PATCH 4/5] perf diff: Use internal rb tree for compute resort Namhyung Kim
2012-12-06 16:51 ` Jiri Olsa [this message]
2012-12-07 8:53 ` Namhyung Kim
2012-12-06 15:09 ` [PATCH 5/5] perf test: Add a test case for hists__{match,link} Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206165136.GA27199@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).