From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424515Ab2LFRAG (ORCPT ); Thu, 6 Dec 2012 12:00:06 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:40524 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424328Ab2LFRAD (ORCPT ); Thu, 6 Dec 2012 12:00:03 -0500 Date: Thu, 6 Dec 2012 08:59:58 -0800 From: Greg Kroah-Hartman To: Cong Ding Cc: Bin Wang , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: [PATCH RFC -next] Fix the trailing blank space issue Message-ID: <20121206165958.GA9301@kroah.com> References: <1354784936-5647-1-git-send-email-wbin00@gmail.com> <20121206154219.GA24788@gmail.com> <20121206160606.GA15256@kroah.com> <20121206163138.GC2510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121206163138.GC2510@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2012 at 04:31:39PM +0000, Cong Ding wrote: > On Thu, Dec 06, 2012 at 08:06:06AM -0800, Greg Kroah-Hartman wrote: > > On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote: > > > On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote: > > > > This patch removes the trailing white space in fs/sysfs/mount.c. > > > > > > > > Signed-off-by: Bin Wang > > > > --- > > > > fs/sysfs/mount.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > Hi Greg, > > > > > > I am not sure it is really necessary to remove all the trailing blank spaces > > > in the project. I have done a try by this shell command > > > $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i > > > and find there are 2812 files/31712 lines with this issue. > > > > That's very true, why would you want to do this? > > > > This comes up every 6 months or so on the linux-kernel mailing list, > > please see the archives for previous responses to the topic. > > > > If you want, just slowly send patches to the different subsystem > > maintainers, to clean the issue up. > sorry for forgetting press "reply all" in the former email... > > Sending them slowly to different subsystem maintainers is a very bad idea, > because it wastes lots of time for both me and them. But the current situation > is that there are some people send this kind of patches in random time which > also is a kind of wasting their time. > > I think we'd better to find a solution, not only for the blank space issue, > but also all the coding style issues able to be fixed by scripts. > > I would suggest to write a series of scripts. And then announce a date > (preferably some holiday like Xmas) to run these scripts. The announce is to > avoid conflicts with other developers. It will save both developers' and > subsystem maintains' time, do you agree? No I do not, it's not a big issue at all. As I said, look in the archives, this comes up every six months or so. greg k-h