From: David Miller <davem@davemloft.net>
To: joseph.gasparakis@intel.com
Cc: bhutchings@solarflare.com, alexander.h.duyck@intel.com,
shemminger@vyatta.com, chrisw@sous-sol.org, gospo@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry@broadcom.com, saeed.bishara@gmail.com,
peter.p.waskiewicz.jr@intel.com
Subject: Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation
Date: Fri, 07 Dec 2012 14:28:45 -0500 (EST) [thread overview]
Message-ID: <20121207.142845.1145515122357569641.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.02.1212071013200.30243@morpheus.jf.intel.com>
From: Joseph Gasparakis <joseph.gasparakis@intel.com>
Date: Fri, 7 Dec 2012 10:24:17 -0800 (PST)
> So the idea here is that the driver will use the headers for checksumming
> if the skb->encapsulation bit is on. The bit should be set in the protocol
> driver.
>
> To answer the second comment, the flags that we use in this series of
> patches is NETIF_F_IP_CSUM, NETIF_F_IPV6_CSUM and NETIF_F_SG. These are
> the bits that we propose will be used for checksumming of encapsulation.
> As per a previous comment in v2, the hw_enc_features field should be used
> also in the future when NICs have more encap offloads, so one could
> indicate these features there from the driver.
>
> Furthermore, I submitted a patch for Rx checksumming, where NETIF_F_RXCSUM
> is used, again in conjunction with skb->encapsulation flag. As I mention
> in my logs, the driver is expected to set the ip_summed to UNNECESSARY and
> turn the skb->encapsulation on, to indicate that the inner headers are
> already HW checksummed.
>
This is the kind of language that belongs in the commit message and
code comments.
next prev parent reply other threads:[~2012-12-07 19:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 1:56 [PATCH v3 net-next 0/4] tunneling: Add support for hardware-offloaded encapsulation Joseph Gasparakis
2012-12-07 1:56 ` [PATCH v3 1/4] net: " Joseph Gasparakis
2012-12-07 10:07 ` Ben Hutchings
2012-12-07 16:45 ` Alexander Duyck
2012-12-07 17:13 ` Ben Hutchings
2012-12-07 18:24 ` Joseph Gasparakis
2012-12-07 19:28 ` David Miller [this message]
2012-12-07 19:41 ` Joseph Gasparakis
2012-12-07 19:37 ` David Miller
2012-12-07 19:52 ` Joseph Gasparakis
2012-12-07 19:52 ` David Miller
2012-12-07 20:18 ` Joseph Gasparakis
2012-12-07 23:15 ` Jeff Kirsher
2012-12-07 1:56 ` [PATCH v3 2/4] net: Handle encapsulated offloads before fragmentation or handing to lower dev Joseph Gasparakis
2012-12-07 23:15 ` Jeff Kirsher
2012-12-07 1:56 ` [PATCH v3 3/4] vxlan: capture inner headers during encapsulation Joseph Gasparakis
2012-12-07 23:16 ` Jeff Kirsher
2012-12-07 1:56 ` [RFC PATCH v3 4/4] ixgbe: Adding tx encapsulation capability Joseph Gasparakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207.142845.1145515122357569641.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=chrisw@sous-sol.org \
--cc=dmitry@broadcom.com \
--cc=gospo@redhat.com \
--cc=joseph.gasparakis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=saeed.bishara@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).