From: Michal Marek <mmarek@suse.cz>
To: Romain Francoise <romain@orebokech.com>
Cc: Pawel Moll <pawel.moll@arm.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Do not remove vmlinux when cleaning external module
Date: Sun, 9 Dec 2012 16:04:34 +0100 [thread overview]
Message-ID: <20121209150434.GB29236@pobox.suse.cz> (raw)
In-Reply-To: <87fw4hzk9i.fsf@silenus.orebokech.com>
On Sat, Nov 10, 2012 at 01:59:21PM +0100, Romain Francoise wrote:
> Pawel Moll <pawel.moll@arm.com> writes:
>
> > Since commit 1f2bfbd00e466ff3489b2ca5cc75b1cccd14c123 "kbuild:
> > link of vmlinux moved to a script" make clean with M=<dir>
> > argument (so cleaning external module) removes vmlinux,
> > System.map and couple of other files from the *main* kernel
> > build directory! This not what was happening before and almost
> > certainly not what one would expect.
>
> > This patch moves makes the clean target of the script called
> > only when !KBUILD_EXTMOD.
>
> Thanks, I have the same problem and this patch fixes it.
>
> Michal, can you pick it up? It's not yet in kbuild.git, it seems.
Sorry for the delay. I applied it to kbuild.git#kbuild now, with
Cc: stable@vger.kernel.org [v3.5+]
Michal
prev parent reply other threads:[~2012-12-09 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 11:23 [PATCH] kbuild: Do not remove vmlinux when cleaning external module Pawel Moll
2012-11-10 12:59 ` Romain Francoise
2012-12-09 15:04 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209150434.GB29236@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).