From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 6/8] mm: vmscan: clean up get_scan_count()
Date: Thu, 13 Dec 2012 17:18:12 +0100 [thread overview]
Message-ID: <20121213161812.GI21644@dhcp22.suse.cz> (raw)
In-Reply-To: <1355348620-9382-7-git-send-email-hannes@cmpxchg.org>
On Wed 12-12-12 16:43:38, Johannes Weiner wrote:
> Reclaim pressure balance between anon and file pages is calculated
> through a tuple of numerators and a shared denominator.
>
> Exceptional cases that want to force-scan anon or file pages configure
> the numerators and denominator such that one list is preferred, which
> is not necessarily the most obvious way:
>
> fraction[0] = 1;
> fraction[1] = 0;
> denominator = 1;
> goto out;
>
> Make this easier by making the force-scan cases explicit and use the
> fractionals only in case they are calculated from reclaim history.
>
> And bring the variable declarations/definitions in order.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
I like this.
Reviewed-by: Michal Hocko <mhocko@suse.cz>
[...]
> @@ -1638,14 +1645,15 @@ static int vmscan_swappiness(struct scan_control *sc)
> static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
> unsigned long *nr)
> {
> - unsigned long anon, file, free;
> + struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat;
> + u64 fraction[2], uninitialized_var(denominator);
> + struct zone *zone = lruvec_zone(lruvec);
> unsigned long anon_prio, file_prio;
> + enum scan_balance scan_balance;
> + unsigned long anon, file, free;
> + bool force_scan = false;
> unsigned long ap, fp;
> - struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat;
> - u64 fraction[2], denominator;
> enum lru_list lru;
> - bool force_scan = false;
> - struct zone *zone = lruvec_zone(lruvec);
You really do love trees, don't you :P
[...]
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2012-12-13 16:18 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 21:43 [patch 0/8] page reclaim bits Johannes Weiner
2012-12-12 21:43 ` [patch 1/8] mm: memcg: only evict file pages when we have plenty Johannes Weiner
2012-12-12 21:53 ` Rik van Riel
2012-12-12 22:28 ` Johannes Weiner
2012-12-13 10:07 ` Mel Gorman
2012-12-13 14:44 ` Mel Gorman
2012-12-13 14:55 ` Michal Hocko
2012-12-16 1:21 ` Simon Jeons
2012-12-17 15:54 ` Michal Hocko
2012-12-19 5:21 ` Simon Jeons
2012-12-19 9:20 ` Mel Gorman
2012-12-13 5:36 ` Simon Jeons
2012-12-13 5:34 ` Simon Jeons
2012-12-12 21:43 ` [patch 2/8] mm: vmscan: disregard swappiness shortly before going OOM Johannes Weiner
2012-12-12 22:01 ` Rik van Riel
2012-12-13 5:56 ` Simon Jeons
2012-12-13 10:34 ` Mel Gorman
2012-12-13 15:29 ` Michal Hocko
2012-12-13 16:05 ` Michal Hocko
2012-12-13 22:25 ` Satoru Moriya
2012-12-14 4:50 ` Johannes Weiner
2012-12-14 8:37 ` Michal Hocko
2012-12-14 15:43 ` Rik van Riel
2012-12-14 16:13 ` Michal Hocko
2012-12-15 0:18 ` Johannes Weiner
2012-12-17 16:37 ` Michal Hocko
2012-12-17 17:54 ` Johannes Weiner
2012-12-17 19:58 ` Michal Hocko
2012-12-14 20:17 ` Satoru Moriya
2012-12-14 19:44 ` Satoru Moriya
2012-12-13 19:05 ` Johannes Weiner
2012-12-13 19:47 ` Mel Gorman
2012-12-12 21:43 ` [patch 3/8] mm: vmscan: save work scanning (almost) empty LRU lists Johannes Weiner
2012-12-12 22:02 ` Rik van Riel
2012-12-13 10:41 ` Mel Gorman
2012-12-13 19:33 ` Johannes Weiner
2012-12-13 15:43 ` Michal Hocko
2012-12-13 19:38 ` Johannes Weiner
2012-12-14 8:46 ` Michal Hocko
2012-12-12 21:43 ` [patch 4/8] mm: vmscan: clarify LRU balancing close to OOM Johannes Weiner
2012-12-12 22:03 ` Rik van Riel
2012-12-13 10:46 ` Mel Gorman
2012-12-12 21:43 ` [patch 5/8] mm: vmscan: improve comment on low-page cache handling Johannes Weiner
2012-12-12 22:04 ` Rik van Riel
2012-12-13 10:47 ` Mel Gorman
2012-12-13 16:07 ` Michal Hocko
2012-12-12 21:43 ` [patch 6/8] mm: vmscan: clean up get_scan_count() Johannes Weiner
2012-12-12 22:06 ` Rik van Riel
2012-12-13 11:07 ` Mel Gorman
2012-12-13 16:18 ` Michal Hocko [this message]
2012-12-12 21:43 ` [patch 7/8] mm: vmscan: compaction works against zones, not lruvecs Johannes Weiner
2012-12-12 22:31 ` Rik van Riel
2012-12-13 11:12 ` Mel Gorman
2012-12-13 16:48 ` Michal Hocko
2012-12-12 21:43 ` [patch 8/8] mm: reduce rmap overhead for ex-KSM page copies created on swap faults Johannes Weiner
2012-12-12 22:34 ` Rik van Riel
2012-12-12 21:50 ` [patch 0/8] page reclaim bits Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213161812.GI21644@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).