From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Waychison <mikew@google.com>
Subject: [PATCH 11/12] firmware/dmi-sysfs: fix sysfs warning on module unload
Date: Fri, 14 Dec 2012 15:03:06 +0400 [thread overview]
Message-ID: <20121214110306.11019.12679.stgit@zurg> (raw)
In-Reply-To: <20121214110229.11019.63713.stgit@zurg>
This removes redundant sysfs_remove_bin_file(), kobject_cleanup() already did this.
[ 1189.278210] ------------[ cut here ]------------
[ 1189.278293] WARNING: at fs/sysfs/inode.c:324 sysfs_hash_and_remove+0xa9/0xb0()
[ 1189.278414] Hardware name: M52S-S3P
[ 1189.278489] sysfs: can not remove 'raw', no directory
[ 1189.278566] Modules linked in: dmi_sysfs(-) mce_inject ar7part mtd decnet cs5535_mfgpt cs5520 eni suni atm cmd640 ide_generic dccp_ipv6 dccp_ipv4 dccp sctp bnep rfcomm bluetooth fuse nfsd exportfs powernow_k8 kvm_amd kvm k8temp parport_pc parport edac_core i2c_nforce2 evbug pcspkr btrfs zlib_deflate libcrc32c ide_core ata_generic pata_acpi sata_nv [last unloaded: dmi_sysfs]
[ 1189.280071] Pid: 5773, comm: rmmod Tainted: P W 3.7.0-rc8-next-20121207+ #594
[ 1189.280200] Call Trace:
[ 1189.280276] [<ffffffff8103bc2a>] warn_slowpath_common+0x7a/0xb0
[ 1189.280355] [<ffffffff8103bd01>] warn_slowpath_fmt+0x41/0x50
[ 1189.280434] [<ffffffff811b9a49>] sysfs_hash_and_remove+0xa9/0xb0
[ 1189.280513] [<ffffffff817f8a16>] ? _raw_spin_unlock+0x26/0x40
[ 1189.280592] [<ffffffff811bd222>] sysfs_remove_bin_file+0x12/0x20
[ 1189.280671] [<ffffffffa0d40a83>] dmi_sysfs_entry_release+0x23/0x58 [dmi_sysfs]
[ 1189.280794] [<ffffffff812d2f13>] kobject_cleanup+0x43/0x80
[ 1189.280872] [<ffffffff812d2f8b>] kobject_put+0x2b/0x60
[ 1189.280951] [<ffffffffa0d40ae8>] cleanup_entry_list+0x30/0x4a [dmi_sysfs]
[ 1189.281043] [<ffffffffa0d40b0b>] dmi_sysfs_exit+0x9/0x23 [dmi_sysfs]
[ 1189.281130] [<ffffffff810a0f43>] sys_delete_module+0x163/0x280
[ 1189.281211] [<ffffffff812ddd84>] ? lockdep_sys_exit_thunk+0x35/0x67
[ 1189.281296] [<ffffffff812ddd0e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 1189.281375] [<ffffffff818009d2>] system_call_fastpath+0x16/0x1b
[ 1189.281453] ---[ end trace e9fbdfe9449ac55f ]---
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mike Waychison <mikew@google.com>
---
drivers/firmware/dmi-sysfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c
index eb26d62..4185f09 100644
--- a/drivers/firmware/dmi-sysfs.c
+++ b/drivers/firmware/dmi-sysfs.c
@@ -553,7 +553,6 @@ static const struct bin_attribute dmi_entry_raw_attr = {
static void dmi_sysfs_entry_release(struct kobject *kobj)
{
struct dmi_sysfs_entry *entry = to_entry(kobj);
- sysfs_remove_bin_file(&entry->kobj, &dmi_entry_raw_attr);
spin_lock(&entry_list_lock);
list_del(&entry->list);
spin_unlock(&entry_list_lock);
next prev parent reply other threads:[~2012-12-14 11:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 11:02 [PATCH 01/12] tools/testing/modules: introduce test which loads/unloads random modules Konstantin Khlebnikov
2012-12-14 11:02 ` [PATCH 02/12] driver core: add debug-objects debug for device-drivers Konstantin Khlebnikov
2012-12-14 11:02 ` [PATCH 03/12] mISDN: fix race in timer canceling on module unloading Konstantin Khlebnikov
2012-12-14 18:16 ` David Miller
2012-12-14 11:02 ` [PATCH 04/12] pps: pps_parport: fix oops " Konstantin Khlebnikov
2012-12-14 11:02 ` [PATCH 05/12] staging: vme_pio2: " Konstantin Khlebnikov
2012-12-17 12:01 ` Martyn Welch
2012-12-14 11:02 ` [PATCH 06/12] media/rc: fix oops on unloading module rc-core Konstantin Khlebnikov
2012-12-14 11:02 ` [PATCH 07/12] stmmac: fix platform driver unregistering Konstantin Khlebnikov
2012-12-14 18:16 ` David Miller
2012-12-14 11:02 ` [PATCH 08/12] bonding: do not cancel works in bond_uninit() Konstantin Khlebnikov
2012-12-14 18:16 ` David Miller
2012-12-14 11:02 ` [PATCH 09/12] pps: fix device destruction ordering Konstantin Khlebnikov
2012-12-14 11:03 ` [PATCH 10/12] mac802154: fix destructon ordering for ieee802154 devices Konstantin Khlebnikov
2012-12-14 18:16 ` David Miller
2012-12-14 11:03 ` Konstantin Khlebnikov [this message]
2012-12-14 11:03 ` [PATCH 12/12] edac: fix kernel panic on module unloading Konstantin Khlebnikov
2012-12-14 11:26 ` Alan Cox
2012-12-14 11:50 ` Borislav Petkov
2012-12-14 11:55 ` Konstantin Khlebnikov
2012-12-14 13:26 ` Alan Cox
2012-12-15 17:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214110306.11019.12679.stgit@zurg \
--to=khlebnikov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).