From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754395Ab2LZMEV (ORCPT ); Wed, 26 Dec 2012 07:04:21 -0500 Received: from mail-vb0-f49.google.com ([209.85.212.49]:36201 "EHLO mail-vb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754351Ab2LZMEU (ORCPT ); Wed, 26 Dec 2012 07:04:20 -0500 Date: Wed, 26 Dec 2012 07:04:15 -0500 From: Tejun Heo To: Li Zefan Cc: paul@paulmenage.org, glommer@parallels.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, peterz@infradead.org, mhocko@suse.cz, bsingharora@gmail.com, hannes@cmpxchg.org, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rusty Russell Subject: Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach() Message-ID: <20121226120415.GA18193@mtj.dyndns.org> References: <1354138460-19286-1-git-send-email-tj@kernel.org> <1354138460-19286-7-git-send-email-tj@kernel.org> <50DACF5B.6050705@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50DACF5B.6050705@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (cc'ing Rusty, hi!) Hello, Li. On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote: > On 2012/11/29 5:34, Tejun Heo wrote: > > cpuset_can_attach() prepare global variables cpus_attach and > > cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). > > There is no reason to prepare in cpuset_can_attach(). The same > > information can be accessed from cpuset_attach(). > > > > Move the prepartion logic from cpuset_can_attach() to cpuset_attach() > > and make the global variables static ones inside cpuset_attach(). > > > > While at it, convert cpus_attach to cpumask_t from cpumask_var_t. > > There's no reason to mess with dynamic allocation on a static buffer. > > > > But Rusty had been deprecating the use of cpumask_t. I don't know why > the final deprecation hasn't been completed yet. Hmmm? cpumask_t can't be used for stack but other than that I don't see how it would be deprecated completely. Rusty, can you please chime in? Thanks. -- tejun