From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742Ab3ABNjL (ORCPT ); Wed, 2 Jan 2013 08:39:11 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:59311 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656Ab3ABNjJ (ORCPT ); Wed, 2 Jan 2013 08:39:09 -0500 Date: Wed, 2 Jan 2013 14:38:43 +0100 From: Thierry Reding To: Philip Avinash Cc: tony@atomide.com, paul@pwsan.com, linux@arm.linux.org.uk, b-cousson@ti.com, hvaibhav@ti.com, anilkumar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com, gururaja.hebbar@ti.com, vaibhav.bedia@ti.com Subject: Re: [PATCH 3/7] pwm: pwm-tiehrpwm: Update the clock handling of pwm-tiehrpwm driver Message-ID: <20130102133843.GA4414@avionic-0098.adnet.avionic-design.de> References: <1357133094-30806-1-git-send-email-avinashphilip@ti.com> <1357133094-30806-4-git-send-email-avinashphilip@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <1357133094-30806-4-git-send-email-avinashphilip@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:rD2rofoIj2pLY+9kbftKXzle/Lj6FrdY9a9U8Wc4Xx9 yeTeoi8uVOog7ebRPI5cZQdz5joJQdzjbtUWRpJaugwQ7WJDQI +WuWt0SOs+lnqSbzvuFP3evXOGJJ2WksYo5qps8q3PytICcu/U MCzkulROwi55z/bfspXJBSclPK+w+0TX0acs4f0SMIxylUQQYw r/xrKUsfWcUTmRUxnNxyIcLfOaf0s93LDUaFOPYGe9eqgYiVVd q9Yyb4Gl+WHB3upEvK2tl713VCXaaiOWDDPtr6TFNA2Yig6HJf dZY6msQgp30IVSIqNWN8ctlc2iSTiB5EH/7NCuwOfyayHAIS0G 6UJp6wJY/uQaxwbHtxe6pmK3uIk1bN4K+s9+xTMooEPTev/nzi erPXUsKfusulejiLvINIY3/NcfCa/UQGas= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 02, 2013 at 06:54:50PM +0530, Philip Avinash wrote: > The clock framework has changed and it's now better to invoke > clock_prepare_enable() and clk_disable_unprepare() rather than the > legacy clk_enable() and clk_disable() calls. This patch converts the > pwm-tiehrpwm driver to the new framework. >=20 > Signed-off-by: Philip Avinash > Cc: Thierry Reding > --- > In 3.8-rc1, common clock frame work support added to AM335x. >=20 > drivers/pwm/pwm-tiehrpwm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c > index 72a6dd4..af6f162 100644 > --- a/drivers/pwm/pwm-tiehrpwm.c > +++ b/drivers/pwm/pwm-tiehrpwm.c > @@ -341,7 +341,7 @@ static int ehrpwm_pwm_enable(struct pwm_chip *chip, s= truct pwm_device *pwm) > configure_polarity(pc, pwm->hwpwm); > =20 > /* Enable TBCLK before enabling PWM device */ > - clk_enable(pc->tbclk); > + clk_prepare_enable(pc->tbclk); I apparently didn't catch this before, but maybe it would be useful to check the return value here to make sure we only proceed if the clock can actually be enabled. Thierry --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQ5DhjAAoJEN0jrNd/PrOhdu8P/12xU5M0R2PV1JLRaFyFOR6i Y1SioRt3GENO+iJdEJGW74PcFBRyzjPxgcGpeaJ6p8ko0YpkT/Q0/HwNeqQ9ZKrb aWmRXy+zlX6kGbxHp208fd4tGu3rwYyC49YUNVybNdtzVwU2KWB6yp0Ij463RYIS /nBZaO/dNOHUzX1JJrBz8qQM/5br0ttztHLy4TH9jkN12yhMxVbk87t6jUikFnzs +Y+xN1FJ8srHGKH63Ndw+BvKLLIgTdXirFW0QUoET9mYc3OGzhlu/oYyDocFzmQk ldekPqJbuwinyzlAGYIjrSutknkx/zAfcjVF7Gnlyauktg39wZTGAVkIllmXhOKG yIOJn0TSn1qWDMLvSkt9yfJ3+1y0CMMmn62xREExB7JTqpPwjEsIGCiXf4pVKB0e Ojh7oDS1qpBX1qGeYB4W/MF0jyOWNtkWgghAqmQrwCdSxwAs0lxnDz1291EAtT6w 7AwPVdUcbhM4FNlAjn0fnl9HW4zmpIFhVRWotJLyR8gxhRDzUBu+sNdgfDy2pO5/ 5JZOgTDwTuQntq49WtvyMdSyDIKqJTvIAeEikvgLhdD/OJKUtTAxKbKsfAbC/XMa CeiDrodNomB0bjUCInUZSBpQ3QuVYPmx3gmIzEdmoNSOHlp4cLFlEXqiQxwH7gH6 Kzmal9AsBItpsF78d1vI =dpiy -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--