From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308Ab3AGTVq (ORCPT ); Mon, 7 Jan 2013 14:21:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755165Ab3AGTVp (ORCPT ); Mon, 7 Jan 2013 14:21:45 -0500 Date: Mon, 7 Jan 2013 20:20:58 +0100 From: Stanislaw Gruszka To: Andreas Hartmann Cc: Ben Hutchings , Johannes Berg , linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Helmut Schaa , "John W. Linville" Subject: Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails Message-ID: <20130107192057.GA17401@redhat.com> References: <20121228190352.097882544@decadent.org.uk> <50DEA41E.6010409@01019freenet.de> <1356871099.4821.16.camel@deadeye.wl.decadent.org.uk> <1356871357.4821.19.camel@deadeye.wl.decadent.org.uk> <20130107080532.GA2984@redhat.com> <20130107081003.GB2984@redhat.com> <1357568256.26822.18.camel@deadeye.wl.decadent.org.uk> <50EAE3E1.4010809@01019freenet.de> <20130107165458.GA16705@redhat.com> <50EB162B.7020903@01019freenet.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50EB162B.7020903@01019freenet.de> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: > Stanislaw Gruszka wrote: > > On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: > >> Ben Hutchings wrote: > >>> On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: > >>>> On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: > >>>>>> To be clear, I have all of these in the queue: > >>>>>> > >>>>>> be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails > >>>>>> 5b632fe85ec8 mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL > >>>>>> ab9d6e4ffe19 Revert: "rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails" > >>>>>> > >>>>>> and I'm intending to drop/defer them all. > >>>>> > >>>>> Patch 3 is a revert of patch 1 (questioned patch). Please apply all 3 patches, > >>>>> or only patch 2. > >>>> > >>>> No, actually all 3 patches have to be applied. Because last one, except > >>>> revert, include flag IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL setting in rt2x00 > >>>> driver, which make patch 2 work. > >>> > >>> Andreas said that that after ab9d6e4ffe19 there was still a regression. > > > > That's not true. There will be no regression after ab9d6e4ffe20. The > > only thing is that solution is not perfect. But perfect solution require > > lot of changes i.e. is not -stable appropriate (and does not exist currently). > > > >>> But maybe he was confused. I know I'm confused. > >> :-)) > >> > >> No, the thing is: > >> rt2800pci misses an appropriate handling of aggregation (which meets the > >> requirements of mac80211). > >> > >> Both workarounds, mine and the new workaround from Stanislaw (which is > >> nothing more than a restricted version of my initial workaround), work > > > > Your workaround broke STA mode on some environment. > > Why are you sure, that this workaround doesn't break some other devices > running in AP mode? We believed at that time too, it wouldn't harm even > STA. But this was wrong for some (which?) devices. Because it make behaviour the same as it was before 3.2, which introduce those issues. Stanislaw