From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619Ab3AGUqI (ORCPT ); Mon, 7 Jan 2013 15:46:08 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:42838 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752870Ab3AGUqG (ORCPT ); Mon, 7 Jan 2013 15:46:06 -0500 Date: Mon, 7 Jan 2013 12:44:36 -0800 From: "Darrick J. Wong" To: OGAWA Hirofumi Cc: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz, ericvh@gmail.com, viro@zeniv.linux.org.uk, rminnich@sandia.gov, tytso@mit.edu, martin.petersen@oracle.com, neilb@suse.de, david@fromorbit.com, Zheng Liu , linux-kernel@vger.kernel.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, bharrosh@panasas.com, jlayton@samba.org, v9fs-developer@lists.sourceforge.net, linux-ext4@vger.kernel.org Subject: Re: [PATCH 4/4] block: Optionally snapshot page contents to provide stable pages during write Message-ID: <20130107204436.GO20106@blackbox.djwong.org> References: <20121213080740.23360.16346.stgit@blackbox.djwong.org> <20121213080811.23360.98131.stgit@blackbox.djwong.org> <877go3z4ra.fsf@devron.myhome.or.jp> <20121227210543.GA20103@blackbox.djwong.org> <87y5gjxj2k.fsf@devron.myhome.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y5gjxj2k.fsf@devron.myhome.or.jp> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 28, 2012 at 06:48:35AM +0900, OGAWA Hirofumi wrote: > "Darrick J. Wong" writes: > > >> I think this flag should be separated into "FS provide stable page" and > >> "FS needs bounce buffer for stable page". > >> > >> My fs (I guess btrfs also) provides stable page by better way, and > >> doesn't need to wait writeback flags too. What needs is just to avoid > >> those stable page stuff. > > > > How does your fs (are we talking about vfat?) provide stable pages? > > Basically it copies the data to another page before modifying data only > if page has writeback flag. (this is about new fs under development stage.) Aha, we're talking about tux3. Since (afaik) there aren't any other filesystems requesting this flag and tux3 uses the device bdi, should I just create a patch and send it to you so it'll be included when tux3 goes in? --D > > > btrfs creates its own bdi and doesn't set the "stable pages required" > > flag, so it already skips all the stable page stuff. > > I see. > -- > OGAWA Hirofumi