From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755557Ab3AJSfR (ORCPT ); Thu, 10 Jan 2013 13:35:17 -0500 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:32606 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754888Ab3AJSfM (ORCPT ); Thu, 10 Jan 2013 13:35:12 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/xM4on3dHnUEOmVHfZ3Cxm Date: Thu, 10 Jan 2013 10:35:01 -0800 From: Tony Lindgren To: Felipe Balbi Cc: kishon , Benoit Cousson , grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk, arnd@arndb.de, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ARM: dts: omap: Add omap-usb2 dt data Message-ID: <20130110183501.GX14149@atomide.com> References: <1348050772-27819-1-git-send-email-kishon@ti.com> <1348050772-27819-3-git-send-email-kishon@ti.com> <50EE8A89.4010801@ti.com> <50EE921D.8020601@ti.com> <50EE9517.3030703@ti.com> <20130110124551.GU28920@arwen.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130110124551.GU28920@arwen.pp.htv.fi> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Felipe Balbi [130110 04:49]: > On Thu, Jan 10, 2013 at 03:46:55PM +0530, kishon wrote: > > On Thursday 10 January 2013 03:34 PM, Benoit Cousson wrote: > > > > > >Rob and I did not agree to use that temp hack in the case of DT, so you > > >were supposed to repost with a proper driver for the SCM part that > > >control the USB. > > > > Ok. Missed that. Will work on that. > > Didn't Tony say we should access SCM directly since it's a one time > thing ? > > Tony ? The SCM parts should be a separate driver that eventually will be a child of the minimal SCM core driver. The reason why it should be separate is because the SCM registers are in a different block as pointed out by Paul. There's a good chance that we'll be able to eventually handle the USB SCM registers directly via pinctrl-single.c using pinconf-bits + generic pinconf binding. That is pending the changes from Haojian to implement generic pinconf for pinctrl-single.c. As the USB SCM registers can get quite complex, I suggest creating a minimal driver to handle that, and then eventually that driver might just use the generic pinconf API for setting the SCM registers for things like bias voltage, pulls and comparators. Regards, Tony