From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756429Ab3AOKPQ (ORCPT ); Tue, 15 Jan 2013 05:15:16 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43229 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963Ab3AOKPN (ORCPT ); Tue, 15 Jan 2013 05:15:13 -0500 Date: Tue, 15 Jan 2013 11:15:06 +0100 From: Jan Kara To: "Darrick J. Wong" Cc: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz, ericvh@gmail.com, tytso@mit.edu, viro@zeniv.linux.org.uk, rminnich@sandia.gov, martin.petersen@oracle.com, neilb@suse.de, Mark Fasheh , david@fromorbit.com, gnehzuil.liu@gmail.com, linux-kernel@vger.kernel.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, ocfs2-devel@oss.oracle.com, bharrosh@panasas.com, jlayton@samba.org, linux-ext4@vger.kernel.org, hirofumi@mail.parknet.co.jp, Joel Becker Subject: Re: [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages Message-ID: <20130115101506.GB1778@quack.suse.cz> References: <20130115054235.1563.12967.stgit@blackbox.djwong.org> <20130115054313.1563.70148.stgit@blackbox.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130115054313.1563.70148.stgit@blackbox.djwong.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 14-01-13 21:43:13, Darrick J. Wong wrote: > When stable pages are required, we have to wait if the page is just > going to disk and we want to modify it. Add proper callback to > ocfs2_grab_pages_for_write(). > > CC: ocfs2-devel@oss.oracle.com > CC: Joel Becker > CC: Mark Fasheh > From: Jan Kara > Signed-off-by: Jan Kara Darrick, to satisfy the kernel patch submission process you should also add your Signed-off-by to the patch... Honza > --- > fs/ocfs2/aops.c | 1 + > 1 file changed, 1 insertion(+) > > > diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c > index 6577432..9796330 100644 > --- a/fs/ocfs2/aops.c > +++ b/fs/ocfs2/aops.c > @@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping, > goto out; > } > } > + wait_for_stable_page(wc->w_pages[i]); > > if (index == target_index) > wc->w_target_page = wc->w_pages[i]; > -- Jan Kara SUSE Labs, CR