From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953Ab3AUK1l (ORCPT ); Mon, 21 Jan 2013 05:27:41 -0500 Received: from host-176-100-244-43.masterbit.su ([176.100.244.43]:44718 "EHLO tservice.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499Ab3AUK1k (ORCPT ); Mon, 21 Jan 2013 05:27:40 -0500 Date: Mon, 21 Jan 2013 14:27:34 +0400 From: Evgeniy Polyakov To: Thierry Reding Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Dmitry Torokhov , Arnd Bergmann , Wolfram Sang Subject: Re: [PATCH 31/33] w1: Convert to devm_ioremap_resource() Message-ID: <20130121102734.GA20620@ioremap.net> References: <1358762966-20791-1-git-send-email-thierry.reding@avionic-design.de> <1358762966-20791-32-git-send-email-thierry.reding@avionic-design.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358762966-20791-32-git-send-email-thierry.reding@avionic-design.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Mon, Jan 21, 2013 at 11:09:24AM +0100, Thierry Reding (thierry.reding@avionic-design.de) wrote: > Convert all uses of devm_request_and_ioremap() to the newly introduced > devm_ioremap_resource() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages so all explicit > error messages can be removed from the failure code paths. > > Signed-off-by: Thierry Reding > Cc: Evgeniy Polyakov Looks good to me Acked-by: Evgeniy Polyakov -- Evgeniy Polyakov