From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: AnilKumar Ch <anilkumar@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: tps65217: Fix using wrong dev argument for calling of_regulator_match
Date: Thu, 24 Jan 2013 12:52:52 +0800 [thread overview]
Message-ID: <20130124045246.GA4955@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1358994450.20257.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
On Thu, Jan 24, 2013 at 10:27:30AM +0800, Axel Lin wrote:
> - count = of_regulator_match(pdev->dev.parent, regs,
> - reg_matches, TPS65217_NUM_REGULATOR);
> + count = of_regulator_match(&pdev->dev, regs, reg_matches,
> + TPS65217_NUM_REGULATOR);
This will break the OF bindings for these regulators as the platform
device doesn't appear in the DT.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-24 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 2:27 [PATCH 1/2] regulator: tps65217: Fix using wrong dev argument for calling of_regulator_match Axel Lin
2013-01-24 2:31 ` [PATCH 2/2] regulator: tps65910: " Axel Lin
2013-01-24 4:45 ` Laxman Dewangan
2013-01-24 17:02 ` gg
2013-01-29 0:03 ` Stephen Warren
2013-01-29 3:39 ` Mark Brown
2013-01-29 18:46 ` Stephen Warren
2013-01-24 4:52 ` Mark Brown [this message]
[not found] ` <CAFRkauDdbYH2jm_TXypjhe0rWyEOpS-JqZ1G4-WZmFKFJngbkw@mail.gmail.com>
2013-01-24 10:00 ` [PATCH 1/2] regulator: tps65217: " Mark Brown
2013-01-24 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124045246.GA4955@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anilkumar@ti.com \
--cc=axel.lin@ingics.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).