From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chanho Min <chanho.min@lge.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH v2] ARM: PL011: Add support for Rx DMA buffer polling
Date: Fri, 25 Jan 2013 12:25:07 -0800 [thread overview]
Message-ID: <20130125202507.GB5470@kroah.com> (raw)
In-Reply-To: <CAOAMb1ACPx6iXWDYz7LnrbRLkLmK9HU7Lro7H5gqpSKr24ooVA@mail.gmail.com>
On Wed, Jan 23, 2013 at 02:07:57PM +0900, Chanho Min wrote:
> On Tue, Jan 22, 2013 at 10:18 PM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> >> - If poll timer is activated, We use consistent DMA mappings to avoid from
> >> the frequent cache operation of the timer function. sg->coherency is used
> >> to check if buffer is coherent.
> >
> > Hm. We can begin like this but maybe we should later patch it to
> > make this the default unless it has performance impacts on our
> > systems.
> Good, I really hope to make this the default.
> We expect it has no impact to system even if no polling use.
>
> > Maybe this is a good opportunity to add some kerneldoc above
> > this struct so as to help platform implementers. It will invariably
> > be reused by Device Tree binding authors later on...
> Agree, but, frankly I need help about what I didn't modify.
> So We will leave this work for the next submit.
So, should this patch be applied? Can I get an ack from someone who
knows this driver/platform please?
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-25 20:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50efad8d.84fc440a.589e.ffff9546SMTPIN_ADDED_BROKEN@mx.google.com>
2013-01-11 18:34 ` [PATCH] ARM: PL011: Add support for Rx DMA buffer polling Linus Walleij
[not found] ` <50f107aa.894e420a.596a.ffffe3f6SMTPIN_ADDED_BROKEN@mx.google.com>
2013-01-14 0:04 ` Linus Walleij
2013-01-14 0:26 ` Russell King - ARM Linux
2013-01-14 6:46 ` Linus Walleij
2013-01-14 7:27 ` Chanho Min
2013-01-14 7:56 ` Linus Walleij
2013-01-14 8:41 ` Chanho Min
2013-01-22 12:45 ` [PATCH v2] " Chanho Min
2013-01-22 13:18 ` Linus Walleij
2013-01-23 5:07 ` Chanho Min
2013-01-25 20:25 ` Greg Kroah-Hartman [this message]
2013-01-25 21:26 ` Russell King - ARM Linux
2013-01-28 8:15 Chanho Min
2013-01-28 8:28 ` Linus Walleij
2013-01-29 2:41 ` Chanho Min
2013-01-29 10:57 ` Linus Walleij
2013-01-30 0:53 ` Chanho Min
2013-01-30 2:53 ` Chanho Min
2013-01-31 20:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125202507.GB5470@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=chanho.min@lge.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).