From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461Ab3AZLDp (ORCPT ); Sat, 26 Jan 2013 06:03:45 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:55732 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753399Ab3AZLDn (ORCPT ); Sat, 26 Jan 2013 06:03:43 -0500 Date: Sat, 26 Jan 2013 11:03:21 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: "Myklebust, Trond" , "netdev@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "J. Bruce Fields" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf' Message-ID: <20130126110321.GE23505@n2100.arm.linux.org.uk> References: <1359123276-15833-1-git-send-email-arnd@arndb.de> <1359153858-31992-16-git-send-email-arnd@arndb.de> <4FA345DA4F4AE44899BD2B03EEEC2FA91833C205@sacexcmbx05-prd.hq.netapp.com> <201301252345.25829.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201301252345.25829.arnd@arndb.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2013 at 11:45:25PM +0000, Arnd Bergmann wrote: > On Friday 25 January 2013, Myklebust, Trond wrote: > > > -----Original Message----- > > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > > Marking it as __maybe_unused avoids a harmless gcc warning. > > > > Alternatively, just declare it using the RPC_IFDEBUG() macro. > > Right, makes sense: that's more consistent with other functions > doing the same thing. Thanks for taking a look. NAK. There is already a fix queued up as a result of a previous report I sent, but for some reason (which I didn't question) it was decided not to queue it for -rc. See Bruce's reply on lkml: 20130108212816.GA24572@fieldses.org