From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linux Containers <containers@lists.linux-foundation.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Aristeu Rozanski <aris@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap.
Date: Sat, 26 Jan 2013 21:08:58 +0000 [thread overview]
Message-ID: <20130126210858.GB11274@mail.hallyn.com> (raw)
In-Reply-To: <87zjzwhegj.fsf@xmission.com>
Quoting Eric W. Biederman (ebiederm@xmission.com):
>
> When I initially wrote the code for /proc/<pid>/uid_map. I was lazy
> and avoided duplicate mappings by the simple expedient of ensuring the
> first number in a new extent was greater than any number in the
> previous extent.
>
> Unfortunately that precludes a number of valid mappings, and someone
> noticed and complained. So use a simple check to ensure that ranges
> in the mapping extents don't overlap.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> ---
> kernel/user_namespace.c | 45 +++++++++++++++++++++++++++++++++++++++------
> 1 files changed, 39 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
> index 24f8ec3..8b65083 100644
> --- a/kernel/user_namespace.c
> +++ b/kernel/user_namespace.c
> @@ -520,6 +520,42 @@ struct seq_operations proc_projid_seq_operations = {
> .show = projid_m_show,
> };
>
> +static bool mappings_overlap(struct uid_gid_map *new_map, struct uid_gid_extent *extent)
> +{
> + u32 upper_first, lower_first, upper_last, lower_last;
> + unsigned idx;
> +
> + upper_first = extent->first;
> + lower_first = extent->lower_first;
> + upper_last = upper_first + extent->count - 1;
> + lower_last = lower_first + extent->count - 1;
> +
> + for (idx = 0; idx < new_map->nr_extents; idx++) {
> + u32 prev_upper_first, prev_lower_first;
> + u32 prev_upper_last, prev_lower_last;
> + struct uid_gid_extent *prev;
> +
> + prev = &new_map->extent[idx];
> +
> + prev_upper_first = prev->first;
> + prev_lower_first = prev->lower_first;
> + prev_upper_last = prev_upper_first + prev->count - 1;
> + prev_lower_last = prev_lower_first + prev->count - 1;
> +
> + /* Does the upper range intersect a previous extent? */
> + if ((prev_upper_first <= upper_last) &&
> + (prev_upper_last >= upper_first))
> + return true;
> +
> + /* Does the lower range intersect a previous extent? */
> + if ((prev_lower_first <= lower_last) &&
> + (prev_lower_last >= lower_first))
> + return true;
> + }
> + return false;
> +}
> +
> +
> static DEFINE_MUTEX(id_map_mutex);
>
> static ssize_t map_write(struct file *file, const char __user *buf,
> @@ -532,7 +568,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
> struct user_namespace *ns = seq->private;
> struct uid_gid_map new_map;
> unsigned idx;
> - struct uid_gid_extent *extent, *last = NULL;
> + struct uid_gid_extent *extent = NULL;
> unsigned long page = 0;
> char *kbuf, *pos, *next_line;
> ssize_t ret = -EINVAL;
> @@ -635,14 +671,11 @@ static ssize_t map_write(struct file *file, const char __user *buf,
> if ((extent->lower_first + extent->count) <= extent->lower_first)
> goto out;
>
> - /* For now only accept extents that are strictly in order */
> - if (last &&
> - (((last->first + last->count) > extent->first) ||
> - ((last->lower_first + last->count) > extent->lower_first)))
> + /* Do the ranges in extent overlap any previous extents? */
> + if (mappings_overlap(&new_map, extent))
> goto out;
>
> new_map.nr_extents++;
> - last = extent;
>
> /* Fail if the file contains too many extents */
> if ((new_map.nr_extents == UID_GID_MAP_MAX_EXTENTS) &&
> --
> 1.7.5.4
next prev parent reply other threads:[~2013-01-26 21:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 2:15 [PATCH review 0/6] miscelaneous user namespace patches Eric W. Biederman
2013-01-26 2:19 ` [PATCH review 1/6] userns: Avoid recursion in put_user_ns Eric W. Biederman
2013-01-26 20:58 ` Serge E. Hallyn
2013-01-28 14:51 ` Vasily Kulikov
2013-01-28 16:34 ` Eric W. Biederman
2013-01-26 2:21 ` [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap Eric W. Biederman
2013-01-26 21:08 ` Serge E. Hallyn [this message]
2013-01-28 14:28 ` Aristeu Rozanski
2013-01-28 14:41 ` Lord Glauber Costa of Sealand
2013-01-28 15:12 ` Aristeu Rozanski
2013-01-26 2:22 ` [PATCH review 3/6] userns: Recommend use of memory control groups Eric W. Biederman
2013-01-26 21:13 ` Serge E. Hallyn
2013-01-27 6:19 ` Eric W. Biederman
2013-01-28 7:37 ` Lord Glauber Costa of Sealand
2013-01-28 7:50 ` Lord Glauber Costa of Sealand
2013-01-28 8:14 ` Eric W. Biederman
2013-01-28 8:22 ` Lord Glauber Costa of Sealand
2013-01-28 16:19 ` Eric W. Biederman
2013-01-28 16:37 ` Lord Glauber Costa of Sealand
2013-01-28 17:18 ` Eric W. Biederman
2013-01-28 8:05 ` Eric W. Biederman
2013-01-26 2:23 ` [PATCH review 4/6] userns: Allow the userns root to mount of devpts Eric W. Biederman
2013-01-26 21:22 ` Serge E. Hallyn
2013-01-26 2:26 ` [PATCH review 5/6] userns: Allow the userns root to mount ramfs Eric W. Biederman
2013-01-26 21:29 ` Serge E. Hallyn
2013-01-27 6:09 ` Eric W. Biederman
2013-01-27 18:23 ` Serge E. Hallyn
2013-01-27 18:23 ` Serge E. Hallyn
2013-01-26 2:26 ` [PATCH review 6/6] userns: Allow the userns root to mount tmpfs Eric W. Biederman
2013-01-27 18:23 ` Serge E. Hallyn
2013-01-28 1:28 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130126210858.GB11274@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=aris@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).