linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gaowanlong@cn.fujitsu.com
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
	mst@redhat.com, jasowang@redhat.com, erdnetdev@gmail.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH V8 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive
Date: Sun, 27 Jan 2013 01:23:56 -0500 (EST)	[thread overview]
Message-ID: <20130127.012356.186129078703210985.davem@davemloft.net> (raw)
In-Reply-To: <1359107491-6749-1-git-send-email-gaowanlong@cn.fujitsu.com>

From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Date: Fri, 25 Jan 2013 17:51:29 +0800

> As Michael mentioned, set affinity and select queue will not work very
> well when CPU IDs are not consecutive, this can happen with hot unplug.
> Fix this bug by traversal the online CPUs, and create a per cpu variable
> to find the mapping from CPU to the preferable virtual-queue.
> 
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Eric Dumazet <erdnetdev@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: virtualization@lists.linux-foundation.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Applied.

      parent reply	other threads:[~2013-01-27  6:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25  9:51 [PATCH V8 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive Wanlong Gao
2013-01-25  9:51 ` [PATCH V8 2/3] virtio-net: split out clean affinity function Wanlong Gao
2013-01-27  6:24   ` David Miller
2013-01-25  9:51 ` [PATCH V8 3/3] virtio-net: reset virtqueue affinity when doing cpu hotplug Wanlong Gao
2013-01-27  6:24   ` David Miller
2013-01-27  6:23 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130127.012356.186129078703210985.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=erdnetdev@gmail.com \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).