From: Ingo Molnar <mingo@kernel.org>
To: Mike Galbraith <bitbucket@online.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] sched: minimalist select_idle_sibling() bouncing cow syndrome fix
Date: Mon, 28 Jan 2013 12:21:45 +0100 [thread overview]
Message-ID: <20130128112145.GA23495@gmail.com> (raw)
In-Reply-To: <1359371965.5783.127.camel@marge.simpson.net>
* Mike Galbraith <bitbucket@online.de> wrote:
> On Mon, 2013-01-28 at 11:53 +0100, Ingo Molnar wrote:
> > * Mike Galbraith <bitbucket@online.de> wrote:
> >
> > > If the previous CPU is cache affine and idle, select it.
> >
> > No objections in principle - but would be nice to have a
> > changelog with numbers, % of improvement included and so?
>
> Well, that like was my changelog, guess it needs improvement.
>
> Take 2.
>
> sched: minimalist select_idle_sibling() bouncing cow syndrome fix
>
> If the previous CPU is cache affine and idle, select it.
>
> The current implementation simply traverses the sd_llc domain,
> taking the first idle CPU encountered, which walks buddy pairs
> hand in hand over the package, inflicting excruciating pain.
>
> 1 tbench pair (worst case) in a 10 core + SMT package:
>
> pre 15.22 MB/sec 1 procs
> post 252.01 MB/sec 1 procs
Drool ... :-)
What would be a 'contrarian' test - i.e. a test where this could
hurt most?
Thanks,
Ingo
next prev parent reply other threads:[~2013-01-28 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 7:50 [patch] sched: minimalist select_idle_sibling() bouncing cow syndrome fix Mike Galbraith
2013-01-28 10:53 ` Ingo Molnar
2013-01-28 11:19 ` Mike Galbraith
2013-01-28 11:21 ` Ingo Molnar [this message]
2013-01-28 11:28 ` Mike Galbraith
2013-02-04 19:25 ` [tip:sched/core] sched: Fix select_idle_sibling() bouncing cow syndrome tip-bot for Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128112145.GA23495@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bitbucket@online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).