From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401Ab3A2UfH (ORCPT ); Tue, 29 Jan 2013 15:35:07 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:65269 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845Ab3A2UfG (ORCPT ); Tue, 29 Jan 2013 15:35:06 -0500 Date: Tue, 29 Jan 2013 12:35:00 -0800 From: Tejun Heo To: aris@redhat.com Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Serge Hallyn Subject: Re: [PATCH v3 9/9] devcg: propagate local changes down the hierarchy Message-ID: <20130129203500.GK6824@mtj.dyndns.org> References: <20130129190759.117458287@napanee.usersys.redhat.com> <20130129190800.590181489@napanee.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130129190800.590181489@napanee.usersys.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Generally looks good to me although I haven't really delved into the behavior (you're gonna be there for the fallouts, right?). Just some minor comments. > +static int propagate_behavior(struct dev_cgroup *devcg_root) > +{ > + struct cgroup *root = devcg_root->css.cgroup, *pos; > + struct dev_cgroup *parent, *devcg, *tmp; > + int rc = 0; > + LIST_HEAD(pending); > + > + rcu_read_lock(); > + cgroup_for_each_descendant_pre(pos, root) { > + devcg = cgroup_to_devcgroup(pos); > + if (is_devcg_online(devcg)) > + list_add_tail(&devcg->propagate_pending, &pending); > + } > + rcu_read_unlock(); I think it could be a good idea to factor out the above and document what's going on and why. Other than that, Acked-by: Tejun Heo Thanks. -- tejun