From: "Pali Rohár" <pali.rohar@gmail.com>
To: Anton Vorontsov <anton@enomsg.org>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bq27x00_battery: Fix reporting battery temperature
Date: Sun, 3 Feb 2013 21:01:54 +0100 [thread overview]
Message-ID: <201302032101.54487@pali> (raw)
In-Reply-To: <20130203034451.GH25016@lizard.sbx00618.mountca.wayport.net>
[-- Attachment #1: Type: Text/Plain, Size: 784 bytes --]
On Sunday 03 February 2013 04:44:51 Anton Vorontsov wrote:
> On Sat, Feb 02, 2013 at 11:06:09AM +0100, Pali Rohár wrote:
> > Reported temperature can be also negative, so cache value in
> > non negative Kelvin degree.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
>
> Applied, thanks!
Now I looked at bq27x00_battery and rx51_battery drivers and I
see that both drivers reporting temperature in different units.
bq27x00_battery in 1/10 °C and rx51_battery in 1/100 °C. What is
correct degree for kernel power power supply API? Maybe other
kernel drivers have different units too... Note that my above
patch did not changed anything units, only fixed reporting
(possible) negative temperature.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-02-03 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 10:06 [PATCH] bq27x00_battery: Fix reporting battery temperature Pali Rohár
2013-02-03 3:44 ` Anton Vorontsov
2013-02-03 20:01 ` Pali Rohár [this message]
2013-02-03 20:05 ` Anton Vorontsov
2013-02-06 17:56 ` Pali Rohár
2013-02-09 1:57 ` Anton Vorontsov
2013-02-09 11:02 ` Pali Rohár
2013-02-16 21:32 ` Anton Vorontsov
2013-03-28 16:42 ` [PATCH] power: rx51_battery: Fix reporting temperature Pali Rohár
2013-04-08 10:50 ` Pali Rohár
2013-04-17 1:33 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302032101.54487@pali \
--to=pali.rohar@gmail.com \
--cc=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).