From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135Ab3BETQB (ORCPT ); Tue, 5 Feb 2013 14:16:01 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:46694 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754890Ab3BETQA (ORCPT ); Tue, 5 Feb 2013 14:16:00 -0500 Date: Tue, 5 Feb 2013 11:15:54 -0800 From: Ben Pfaff To: Cong Wang Cc: Stephen Hemminger , Rusty Russell , Jesse Gross , "David S. Miller" , LKML , Linux Kernel Network Developers Subject: Re: No sysfs directory for openvswitch module when built-in Message-ID: <20130205191554.GA7573@blp.benpfaff.org> References: <20130204081920.00e9f22e@nehalam.linuxnetplumber.net> <87lib3gunm.fsf@blp.benpfaff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 05, 2013 at 06:49:45PM +0800, Cong Wang wrote: > On Tue, Feb 5, 2013 at 2:08 PM, Ben Pfaff wrote: > > Stephen Hemminger writes: > > > >> On Tue, 29 Jan 2013 22:15:18 +0800 > >> Cong Wang wrote: > >> > >>> Hello, Rusty, Jesse, > >>> > >>> I met an interesting problem when I compile openvswitch module as a > >>> built-in (actually I compile ALL kernel modules as built-in), there is > >>> no /sys/module/openvswitch/ directory created by the kernel in this > >>> case. > >>> > >>> What's worse, the user-space init script thinks openvswitch module is > >>> not loaded by checking the exist of this directory, therefore refuses > >>> to start. > >> > >> Shouldn't the OVS init script be testing for some other API. > > > > I agree that's a bug in the OVS init script. I will fix it. > > Thanks for taking care of it, Ben! I posted a patch to ovs-dev for review: http://openvswitch.org/pipermail/dev/2013-February/025128.html