From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method
Date: Tue, 5 Feb 2013 17:42:59 -0800 [thread overview]
Message-ID: <20130206014259.GC816@kroah.com> (raw)
In-Reply-To: <20130206011721.GE11197@blaptop>
On Wed, Feb 06, 2013 at 10:17:21AM +0900, Minchan Kim wrote:
> > > > Did you test this? I don't see the new config value you added actually
> > > > do anything in this code. Also, if I select it incorrectly on ARM, or
> > >
> > > *slaps self*
> >
> > Ok, so I'll drop this patch now. As for what to do instead, I have no
> > idea, sorry, but the others should.
>
> Okay. Then, let's discuss further.
> The history we introuced copy-based method is due to portability casused by
> set_pte and __flush_tlb_one usage in young zsmalloc age. They are gone now
> so there isn't issue any more. But we found copy-based method is 3 times faster
> than pte-based in VM so I expect you guys don't want to give up it for just
> portability. Of course,
> I can't give up pte-based model as you know well, it's 6 times faster than
> copy-based model in ARM.
>
> Hard-coding for some arch like now isn't good and Kconfig for selecting choice
> was rejected by Greg as you can see above.
I rejected your patch because it did not do anything, why would I accept
it?
What would you have done in my situation?
It's not an issue of "portability" or "speed" or anything other than
"the patch you sent was obviously not correct."
greg k-h
next prev parent reply other threads:[~2013-02-06 1:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 0:23 [PATCH] zsmalloc: Add Kconfig for enabling PTE method Minchan Kim
2013-02-04 2:02 ` Simon Jeons
2013-02-04 2:58 ` Minchan Kim
2013-02-04 18:51 ` Greg Kroah-Hartman
2013-02-05 0:08 ` Minchan Kim
2013-02-05 19:25 ` Greg Kroah-Hartman
2013-02-06 1:17 ` Minchan Kim
2013-02-06 1:42 ` Greg Kroah-Hartman [this message]
2013-02-06 1:44 ` Minchan Kim
2013-02-16 6:28 ` Ric Mason
2013-02-18 18:24 ` Seth Jennings
2013-02-18 23:48 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206014259.GC816@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).