From: Antonio Quartulli <ordex@autistici.org>
To: Emil Goode <emilgoode@gmail.com>
Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de,
davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] batman-adv: Remove unused variable
Date: Wed, 6 Feb 2013 20:55:57 +0100 [thread overview]
Message-ID: <20130206195557.GC6008@ritirata.org> (raw)
In-Reply-To: <1360173353.22154.4.camel@debian>
[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]
Hi Emil,
On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote:
> Hi Antonio,
>
> The commit ed242d01 is in the linux-next tree and my patch depends on
> that commit.
>
Yes, you are right. I was not aware of this commit, because the author
did not CC us (neither netdev) even if he changed the code we maintain.
As far as I can see that commit is in linux-next only.
Therefore it must be applied there.
However, I'd like you to change the commit message and write the full hash of
the commit you are referring to and its subject ("LIKE THIS"). This would make
it easier to find it.
Regards,
> Best regards, Emil
>
> On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> > Hi Emil,
> >
> > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > > The commit ed242d01 removed a node parameter from iterators.
> > > This patch removes a hlist_node struct that is no longer used.
> > >
> > > Sparse gives a warning:
> > >
> > > net/batman-adv/originator.c:411:21: warning:
> > > unused variable ‘node_tmp’ [-Wunused-variable]
> > >
> > > Signed-off-by: Emil Goode <emilgoode@gmail.com>
> >
> > On which tree did you base your patch?
> > I cannot find the commit you are referring to (ed242d01) and the patch does not
> > apply (neither on net nor net-next).
> >
> > Other than that the variable is used a couple of lines below (in the code we
> > have)...
> >
> > Regards,
> >
>
>
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-06 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 16:37 [PATCH] batman-adv: Remove unused variable Emil Goode
2013-02-06 17:22 ` Antonio Quartulli
2013-02-06 17:55 ` Emil Goode
2013-02-06 19:55 ` Antonio Quartulli [this message]
2013-02-06 21:59 ` Emil Goode
2013-02-06 22:10 ` Antonio Quartulli
2013-02-06 22:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206195557.GC6008@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lindner_marek@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).