From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Amit Daniel Kachhap <amit.daniel@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
Sangbeom Kim <sbkim73@samsung.com>,
LiamGirdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places
Date: Fri, 8 Feb 2013 11:20:28 +0000 [thread overview]
Message-ID: <20130208112027.GI8879@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1360119412.8965.3.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote:
> Use &pdev->dev rather than iodev->dev for dev_err(), dev_warn() and dev_info().
It's not clear to me that this is actually an improvement, the pdev is
mostly just an internal Linux implementation detail so it's common to
use the physical device for MFD logging in order to help the user
understand what's causing the log message.
> Use &pdev->dev rather than iodev->dev for devm_kzalloc() and
> of_get_regulator_init_data(), this fixes memory leak.
This is a good fix though. This sort of thing is one reason for
splitting out unrelated changes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-08 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 2:55 [PATCH 1/3] regulator: s5m8767: Use of_get_child_count() Axel Lin
2013-02-06 2:56 ` [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places Axel Lin
2013-02-08 11:20 ` Mark Brown [this message]
2013-02-10 10:15 ` Axel Lin
2013-02-06 2:58 ` [PATCH 3/3] regulator: s5m8767: Prevent possible NULL pointer dereference Axel Lin
2013-02-08 11:22 ` [PATCH 1/3] regulator: s5m8767: Use of_get_child_count() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208112027.GI8879@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=amit.daniel@samsung.com \
--cc=axel.lin@ingics.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sbkim73@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).