From: Mark Rutland <mark.rutland@arm.com>
To: Roger Quadros <rogerq@ti.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"b-cousson@ti.com" <b-cousson@ti.com>,
"balbi@ti.com" <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"kishon@ti.com" <kishon@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/14] USB: ohci-omap3: Add device tree support and binding information
Date: Mon, 11 Feb 2013 15:32:17 +0000 [thread overview]
Message-ID: <20130211153217.GB15013@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <51190CA7.7010705@ti.com>
> >> +Required properties:
> >> +
> >> +- compatible: should be "ti,ohci-omap3"
> >> +- reg: should contain one register range i.e. start and length
> >> +- interrupt-parent: phandle to the interrupt controller
> >
> > I'm not sure that needs to be documented as a required property. It's a
> > standard property, and if it's defined for the parent node, you won't need it
> > here.
>
> The last time I tried without 'interrupt-parent' it complained. Doesn't do it anymore.
> Maybe I did something wrong the last time. I'll remove it.
>
> >
> > Otherwise, this looks fine to me.
>
> Thanks. I'll add your reviewed-by tag after addressing the above comment.
Sure.
Thanks,
Mark.
next prev parent reply other threads:[~2013-02-11 15:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 16:02 [PATCH v2 00/14] Device tree support for OMAP HS USB Host Roger Quadros
2013-02-07 16:02 ` [PATCH v2 01/14] usb: phy: nop: Add device tree support and binding information Roger Quadros
2013-02-11 11:40 ` Mark Rutland
2013-02-11 15:14 ` Roger Quadros
2013-02-11 15:31 ` Mark Rutland
2013-02-07 16:02 ` [PATCH v2 02/14] USB: phy: nop: Defer probe if device needs VCC/RESET Roger Quadros
2013-02-07 16:02 ` [PATCH v2 03/14] mfd: omap-usb-tll: move configuration code to omap_tll_init() Roger Quadros
2013-02-07 16:02 ` [PATCH v2 04/14] mfd: omap-usb-tll: Add device tree support Roger Quadros
2013-02-07 16:02 ` [PATCH v2 05/14] USB: ehci-omap: Get platform resources by index rather than by name Roger Quadros
2013-02-07 16:02 ` [PATCH v2 06/14] USB: ohci-omap3: " Roger Quadros
2013-02-07 16:02 ` [PATCH v2 07/14] USB: ohci-omap3: Add device tree support and binding information Roger Quadros
2013-02-11 11:46 ` Mark Rutland
2013-02-11 15:22 ` Roger Quadros
2013-02-11 15:32 ` Mark Rutland [this message]
2013-02-07 16:02 ` [PATCH v2 08/14] USB: ehci-omap: " Roger Quadros
2013-02-11 11:52 ` Mark Rutland
2013-02-07 16:02 ` [PATCH v2 09/14] mfd: omap-usb-host: " Roger Quadros
2013-02-11 12:00 ` Mark Rutland
2013-02-11 15:24 ` Roger Quadros
2013-02-07 16:02 ` [PATCH v2 10/14] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-02-07 16:02 ` [PATCH v2 11/14] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-02-07 16:02 ` [PATCH v2 12/14] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-02-07 16:02 ` [PATCH v2 13/14] ARM: dts: omap3-beagle: Add USB Host support Roger Quadros
2013-02-07 16:02 ` [PATCH v2 14/14] USB: ehci-omap: Fix autoloading of module Roger Quadros
2013-02-07 16:11 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211153217.GB15013@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).