linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, eranian@google.com,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/5] perf, x86: Add PEBSv2 record support v2
Date: Tue, 12 Feb 2013 10:02:50 +0100	[thread overview]
Message-ID: <20130212090250.GC19475@gmail.com> (raw)
In-Reply-To: <1360265019-23865-2-git-send-email-andi@firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> Add support for the v2 PEBS format. It has a superset of the v1 PEBS
> fields, but has a longer record so we need to adjust the code paths.

The changelog talks about a 'v2' PEBS format - the code talks 
about 'fmt2':

> +/*
> + * Same as pebs_record_nhm, with two additional fields.
> + */
> +struct pebs_record_fmt2 {

In light of the existing pebs_record_core and pebs_record_nhm 
naming a new perf_record_hsw would be more natural.

Or if numbered versions are used, all PEBS record hardware 
versions should be numbered.

Right now your extension makes it all look pretty inconsistent.

Thanks,

	Ingo

  reply	other threads:[~2013-02-12  9:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07 19:23 Basic perf PMU support for Haswell v5 Andi Kleen
2013-02-07 19:23 ` [PATCH 1/5] perf, x86: Add PEBSv2 record support v2 Andi Kleen
2013-02-12  9:02   ` Ingo Molnar [this message]
2013-02-07 19:23 ` [PATCH 2/5] perf, x86: Basic Haswell PMU support v4 Andi Kleen
2013-02-07 19:23 ` [PATCH 3/5] perf, x86: Basic Haswell PEBS " Andi Kleen
2013-02-07 19:23 ` [PATCH 4/5] perf, x86: Support full width counting v2 Andi Kleen
2013-02-12  8:42   ` Ingo Molnar
2013-02-07 19:23 ` [PATCH 5/5] perf, x86: Move NMI clearing to end of PMI handler after the counter registers are reset Andi Kleen
2013-02-12  8:43   ` Ingo Molnar
2013-02-12 15:14     ` Andi Kleen
2013-02-13  9:10       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2013-02-05  1:49 Basic perf PMU support for Haswell v4 Andi Kleen
2013-02-05  1:49 ` [PATCH 1/5] perf, x86: Add PEBSv2 record support v2 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130212090250.GC19475@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).