From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, acme@redhat.com, jolsa@redhat.com,
namhyung.kim@lge.com
Subject: Re: [PATCH 0/2] perf stat: add per-core count aggregation
Date: Tue, 12 Feb 2013 09:23:19 -0800 [thread overview]
Message-ID: <20130212172319.GB30387@tassilo.jf.intel.com> (raw)
In-Reply-To: <1360678168-6974-1-git-send-email-eranian@google.com>
On Tue, Feb 12, 2013 at 03:09:26PM +0100, Stephane Eranian wrote:
> This patch series contains improvement to the aggregation support
> in perf stat.
>
> First, the aggregation code is refactored and a aggr_mode enum
> is defined. There is also an important bug fix for the existing
> per-socket aggregation.
>
> Second, the patch adds a new --aggr-core option to perf stat.
Perhaps it's just me, but the option name is ugly (and sounds
aggressive)
--per-core perhaps?
The idea itself is useful.
> It aggregates counts per physical core and becomes useful on
> systems with hyper-threading. The cores are presented per
> socket: S0-C1, means socket 0 core 1. Note that the core number
> represents its physical core id. As such, numbers may not always
> be contiguous. All of this is based on topology information available
> in sysfs.
>
> Per-core aggregation can be combined with interval printing:
FWIW this would be much nicer if stat had a Kevents or Mevents mode.
Usually we don't need all the digits. But that could be added separately
Does it work for multiple events in parallel?
>
> # perf stat -a --aggr-core -I 1000 -e cycles sleep 100
> # time core cpus counts events
> 1.000101160 S0-C0 2 6,051,254,899 cycles
> 1.000101160 S0-C1 2 6,379,230,776 cycles
> 1.000101160 S0-C2 2 6,480,268,471 cycles
> 1.000101160 S0-C3 2 6,110,514,321 cycles
> 2.000663750 S0-C0 2 6,572,533,016 cycles
> 2.000663750 S0-C1 2 6,378,623,674 cycles
> 2.000663750 S0-C2 2 6,264,127,589 cycles
> 2.000663750 S0-C3 2 6,305,346,613 cycles
-Andi
next prev parent reply other threads:[~2013-02-12 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 14:09 [PATCH 0/2] perf stat: add per-core count aggregation Stephane Eranian
2013-02-12 14:09 ` [PATCH 1/2] perf stat: refactor aggregation code Stephane Eranian
2013-02-12 17:26 ` Andi Kleen
2013-02-13 7:50 ` Namhyung Kim
2013-02-13 9:38 ` Stephane Eranian
2013-02-12 14:09 ` [PATCH 2/2] perf stat: add per-core aggregation Stephane Eranian
2013-02-12 17:23 ` Andi Kleen [this message]
2013-02-12 17:26 ` [PATCH 0/2] perf stat: add per-core count aggregation Stephane Eranian
2013-02-12 17:29 ` Andi Kleen
2013-02-12 17:33 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212172319.GB30387@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).