From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Takashi Iwai <tiwai@suse.de>,
axboe@kernel.dk, cbou@mail.ru, davem@davemloft.net,
dwmw2@infradead.org, grant.likely@secretlab.ca,
gregkh@linuxfoundation.org, jkosina@suse.cz, jslaby@suse.cz,
khali@linux-fr.org, mchehab@redhat.com, perex@perex.cz,
sameo@linux.intel.com, w.sang@pengutronix.de,
linux-kernel@vger.kernel.org, sebott@linux.vnet.ibm.com,
gerald.schaefer@de.ibm.com, schwidefsky@de.ibm.com
Subject: Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies
Date: Wed, 13 Feb 2013 13:34:05 -0800 [thread overview]
Message-ID: <20130213213405.GA23390@core.coreip.homeip.net> (raw)
In-Reply-To: <201302062156.55910.arnd@arndb.de>
On Wed, Feb 06, 2013 at 09:56:55PM +0000, Arnd Bergmann wrote:
> On Wednesday 06 February 2013, Heiko Carstens wrote:
> >
> > I haven't looked into it, but I doubt if that is possible without large
> > effort, if at all. s390 doesn't have any irq chips, nor something like
> > edge or level triggered irqs.
> > Instead we have floating interrupts. Does that fit into the concept of
> > GENERIC_HARDIRQS at all?
> > If so, we can give it a try, sure. But that won't happen any time soon.
> >
> > Or are you simply proposing we should have both, our own irq handling plus
> > GENERIC_HARDIRQS with dummy functions?
>
> I think you should use GENERIC_HARDIRQ just for PCI, and rename the s390
> interrupt handling to something that does not conflict. I understand
> that the concepts are quite different, but with PCI support, you actually
> do get all the weird interrupt hardware.
> More importantly, some features provided by GENERIC_HARDIRQ are replacing
> the traditional interfaces now, e.g. devm_request_irq() is actually
> recommended over request_irq() for normal drivers these days, as it
> simplifies the error handling.
I would be very careful with this statement. While devm_request_irq()
does simplify error handling in several cases I have also seen countless
examples when it was used with non devm_*-managed structures that are
freed by hand opening race window where interrupts can be delivered and
use structure that is already freed.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-02-13 21:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 16:23 [PATCH 00/15] Add various missing GENERIC_HARDIRQS dependencies Heiko Carstens
2013-02-06 16:23 ` [PATCH 01/15] drivers/input: add couple of " Heiko Carstens
2013-02-14 4:22 ` Dmitry Torokhov
2013-02-06 16:23 ` [PATCH 02/15] drivers/i2c: remove !S390 dependency, add " Heiko Carstens
2013-02-06 16:23 ` [PATCH 03/15] drivers/mfd: add missing GENERIC_HARDIRQS dependecies Heiko Carstens
2013-02-07 7:39 ` Samuel Ortiz
2013-02-06 16:23 ` [PATCH 04/15] drivers/block/mtip32xx: add missing GENERIC_HARDIRQS dependency Heiko Carstens
2013-02-07 6:35 ` Jens Axboe
2013-02-06 16:23 ` [PATCH 05/15] drivers/dma/dw_dmac: " Heiko Carstens
2013-02-06 16:23 ` [PATCH 06/15] drivers/gpio: add missing GENERIC_HARDIRQ dependency Heiko Carstens
2013-02-06 16:23 ` [PATCH 07/15] drivers/hid: " Heiko Carstens
2013-02-07 10:37 ` Jiri Kosina
2013-02-06 16:23 ` [PATCH 08/15] drivers/misc/cb710: add missing GENERIC_HARDIRQS dependency Heiko Carstens
2013-02-08 20:23 ` Greg KH
2013-02-08 20:23 ` Greg KH
2013-02-06 16:23 ` [PATCH 09/15] drivers/media: add missing GENERIC_HARDIRQS dependencies Heiko Carstens
2013-02-07 14:01 ` Mauro Carvalho Chehab
2013-02-06 16:23 ` [PATCH 10/15] drivers/net,AT91RM9200: add missing GENERIC_HARDIRQS dependency Heiko Carstens
2013-02-06 21:12 ` David Miller
2013-02-06 16:23 ` [PATCH 11/15] drivers/spi: add missing GENERIC_HARDIRQS dependencies Heiko Carstens
2013-02-06 16:24 ` [PATCH 12/15] sound: add missing HAS_IOPORT and " Heiko Carstens
2013-02-06 17:05 ` Takashi Iwai
2013-02-07 1:13 ` Arnd Bergmann
2013-02-06 17:26 ` Takashi Iwai
2013-02-06 18:12 ` Heiko Carstens
2013-02-06 21:56 ` Arnd Bergmann
2013-02-07 13:32 ` Heiko Carstens
2013-02-07 13:36 ` Arnd Bergmann
2013-02-07 13:39 ` Takashi Iwai
2013-02-13 21:34 ` Dmitry Torokhov [this message]
2013-02-06 16:24 ` [PATCH 13/15] drivers/usb: add missing " Heiko Carstens
2013-02-06 16:24 ` [PATCH 14/15] drivers/power,goldfisch battery: add missing GENERIC_HARDIRQS dependency Heiko Carstens
2013-02-16 21:24 ` Anton Vorontsov
2013-02-06 16:24 ` [PATCH 15/15] drivers/serial: add " Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213213405.GA23390@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=cbou@mail.ru \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=perex@perex.cz \
--cc=sameo@linux.intel.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=tiwai@suse.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).