From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965232Ab3BMW7P (ORCPT ); Wed, 13 Feb 2013 17:59:15 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:54393 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859Ab3BMW7O (ORCPT ); Wed, 13 Feb 2013 17:59:14 -0500 From: Grant Likely Subject: Re: [PATCH 4/4] of/pci: Add of_pci_parse_bus_range() function To: Thierry Reding Cc: Rob Herring , Andrew Murray , Thomas Petazzoni , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <1360570940-17086-5-git-send-email-thierry.reding@avionic-design.de> References: <1360570940-17086-1-git-send-email-thierry.reding@avionic-design.de> <1360570940-17086-5-git-send-email-thierry.reding@avionic-design.de> Date: Wed, 13 Feb 2013 22:58:44 +0000 Message-Id: <20130213225844.B79093E3557@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Feb 2013 09:22:20 +0100, Thierry Reding wrote: > This function can be used to parse a bus-range property as specified by > device nodes representing PCI bridges. > > Signed-off-by: Thierry Reding Ditto for this one. We can wait on it until there is a user. > --- > drivers/of/of_pci.c | 25 +++++++++++++++++++++++++ > include/linux/of_pci.h | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > index d6e6de5..fb92ded 100644 > --- a/drivers/of/of_pci.c > +++ b/drivers/of/of_pci.c > @@ -85,3 +85,28 @@ int of_pci_get_devfn(struct device_node *np) > return (be32_to_cpup(reg) >> 8) & 0xff; > } > EXPORT_SYMBOL_GPL(of_pci_get_devfn); > + > +/** > + * of_pci_parse_bus_range() - parse the bus-range property of a PCI device > + * @node: device node > + * @res: address to a struct resource to return the bus-range > + * > + * Returns 0 on success or a negative error-code on failure. > + */ > +int of_pci_parse_bus_range(struct device_node *node, struct resource *res) > +{ > + const __be32 *values; > + int len; > + > + values = of_get_property(node, "bus-range", &len); > + if (!values || len < sizeof(*values) * 2) > + return -EINVAL; > + > + res->name = node->name; > + res->start = be32_to_cpup(values++); > + res->end = be32_to_cpup(values); > + res->flags = IORESOURCE_BUS; Is there precedence for using struct resource for passing around the PCI bus range values? Who will be the user of this function? g.