From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752468Ab3BPIaA (ORCPT ); Sat, 16 Feb 2013 03:30:00 -0500 Received: from mail-ee0-f49.google.com ([74.125.83.49]:42553 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab3BPI37 (ORCPT ); Sat, 16 Feb 2013 03:29:59 -0500 Date: Sat, 16 Feb 2013 09:29:54 +0100 From: Ingo Molnar To: Greg KH Cc: Yinghai Lu , Greg KH , Thomas Gleixner , Linus Torvalds , Linux Kernel Mailing List , Jens Axboe , Alexander Viro , "Theodore Ts'o" , "H. Peter Anvin" , Laura Abbott , Mel Gorman Subject: Re: [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to_bitidx calculation" Message-ID: <20130216082954.GA18953@gmail.com> References: <20130213111007.GA11367@gmail.com> <20130214144510.GC25282@gmail.com> <20130214145424.GA26071@gmail.com> <20130214150810.GA26095@gmail.com> <20130215114425.GD26955@gmail.com> <20130215220615.GA1696@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130215220615.GA1696@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg KH wrote: > On Fri, Feb 15, 2013 at 12:44:26PM +0100, Ingo Molnar wrote: > > > > [ Greg: -stable was Cc:-ed for this potentially buggy commit. ] > > > > * Yinghai Lu wrote: > > > > > On Thu, Feb 14, 2013 at 7:08 AM, Ingo Molnar wrote: > > > > these three: > > > > > > > > 10d73e655cef mm: bootmem: fix free_all_bootmem_core() with odd bitmap alignment > > > > c060f943d092 mm: use aligned zone start for pfn_to_bitidx calculation > > > > c0232ae861df mm: memblock: fix wrong memmove size in memblock_merge_regions() > > > > > > > > might have highmem=512m boot parameter sensitivity. > > > > > > 10d73e655cef should not be related, as we are using nobootmem wrapper > > > of memblock. > > > c0232ae861df is copying less while using the blank slot in memblock > > > memory or reserved array > > > so it should be ok too. > > > > > > c060f943d092 may be related as you config does not have > > > CONFIG_SPARSEMEM defined. > > > > Right, that's the commit causing the x86 regression: > > > > c060f943d0929f3e429c5d9522290584f6281d6e is the first bad commit > > commit c060f943d0929f3e429c5d9522290584f6281d6e > > Date: Fri Jan 11 14:31:51 2013 -0800 > > > > mm: use aligned zone start for pfn_to_bitidx calculation > > > > I've given 6d92d4f (its parent commit) quite a bit of testing so > > I'm 99% sure in the validity of this bisection result. > > > > Involved parties Cc:-ed. > > > > Revert attached below - it reverts cleanly and I'll test this > > today, to see whether this solves the sporadic lockups. > > > > Thanks, > > > > Ingo > > > > -------------------> > > >From 6f3d5a8f38eb23f792b408d9bc8fee53a7d158f9 Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar > > Date: Fri, 15 Feb 2013 12:43:22 +0100 > > Subject: [PATCH] Revert "mm: use aligned zone start for pfn_to_bitidx > > calculation" > > > > This reverts commit c060f943d0929f3e429c5d9522290584f6281d6e. > > Let me know if I should be reverting this from the -stable releases. It appears so - it definitely locks up here with the config I sent. It appears to be a rare bug but a bug. Would be nice to hear from the authors/ackers/pushers of the patch though. Thanks, Ingo