From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755159Ab3BQBgw (ORCPT ); Sat, 16 Feb 2013 20:36:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:43909 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384Ab3BQBgv (ORCPT ); Sat, 16 Feb 2013 20:36:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,681,1355126400"; d="scan'208";a="263635016" Date: Sun, 17 Feb 2013 09:36:49 +0800 From: Fengguang Wu To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Glauber Costa , Tony Luck , Fenghua Yu Subject: Re: [PATCH] ia64: rename cache_show to topology_cache_show Message-ID: <20130217013649.GB6775@localhost> References: <511e236a.o0ibbB2U8xMoURgd%fengguang.wu@intel.com> <1360931904-5720-1-git-send-email-mhocko@suse.cz> <20130215144629.be18bae9.akpm@linux-foundation.org> <20130216121853.GA12196@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130216121853.GA12196@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 16, 2013 at 01:18:53PM +0100, Michal Hocko wrote: > On Fri 15-02-13 14:46:29, Andrew Morton wrote: > > On Fri, 15 Feb 2013 13:38:24 +0100 > > Michal Hocko wrote: > > > > > Fenguang Wu has reported the following compile time issue > > > arch/ia64/kernel/topology.c:278:16: error: conflicting types for 'cache_show' > > > include/linux/slab.h:224:5: note: previous declaration of 'cache_show' was here > > > > > > which has been introduced by 749c5415 (memcg: aggregate memcg cache > > > values in slabinfo). Let's rename ia64 local function to prevent from > > > the name conflict. > > > > Confused. Tony fixed this ages ago? > > Yes but it was after 3.7 so I didn't have it in my tree and I found out > only after I sent this email. Sorry about the confusion. Michal, sorry about the confusions. Does this indicate anything improveable in the build test/notification? Thanks, Fengguang