From: Shawn Guo <shawn.guo@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: <mturquette@linaro.org>, <linux-kernel@vger.kernel.org>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] clk: mxs: Fix sparse warnings
Date: Sun, 17 Feb 2013 16:02:20 +0800 [thread overview]
Message-ID: <20130217080219.GF15048@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1360591636-10575-1-git-send-email-festevam@gmail.com>
On Mon, Feb 11, 2013 at 12:07:16PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following sparse warnings:
>
> drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static?
> drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/clk/mxs/clk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/mxs/clk.c b/drivers/clk/mxs/clk.c
> index b24d560..5301bce 100644
> --- a/drivers/clk/mxs/clk.c
> +++ b/drivers/clk/mxs/clk.c
> @@ -13,6 +13,7 @@
> #include <linux/io.h>
> #include <linux/jiffies.h>
> #include <linux/spinlock.h>
> +#include "clk.h"
>
> DEFINE_SPINLOCK(mxs_lock);
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-02-17 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 14:07 [PATCH] clk: mxs: Fix sparse warnings Fabio Estevam
2013-02-17 8:02 ` Shawn Guo [this message]
2013-03-19 20:10 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130217080219.GF15048@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).