From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Li Zefan <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH] cgroup: fail if monitored file and event_control are in different cgroup
Date: Mon, 18 Feb 2013 12:24:11 +0200 [thread overview]
Message-ID: <20130218102411.GA3394@shutemov.name> (raw)
In-Reply-To: <5121C68F.1000309@huawei.com>
On Mon, Feb 18, 2013 at 02:13:35PM +0800, Li Zefan wrote:
> If we pass fd of memory.usage_in_bytes of cgroup A to cgroup.event_control
> of cgroup B, then we won't get memory usage notification from A but B!
>
> What's worse, if A and B are in different mount hierarchy, we'll end up
> accessing NULL pointer!
>
> Disallow this kind of invalid usage.
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2013-02-18 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 6:13 [PATCH] cgroup: fail if monitored file and event_control are in different cgroup Li Zefan
2013-02-18 10:24 ` Kirill A. Shutemov [this message]
2013-02-18 17:32 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218102411.GA3394@shutemov.name \
--to=kirill@shutemov.name \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).