From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alexander Holler <holler@ahsoftware.de>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
linux-input@vger.kernel.org, srinivas.pandruvada@intel.com
Subject: Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus
Date: Mon, 18 Feb 2013 13:33:20 +0200 [thread overview]
Message-ID: <20130218113320.GA2338@intel.com> (raw)
In-Reply-To: <51220F12.2060908@ahsoftware.de>
On Mon, Feb 18, 2013 at 12:22:58PM +0100, Alexander Holler wrote:
> Am 18.02.2013 12:12, schrieb Mika Westerberg:
> >On Mon, Feb 18, 2013 at 12:03:04PM +0100, Alexander Holler wrote:
> >>Am 11.02.2013 11:31, schrieb Mika Westerberg:
> >>>We now have two transport mediums: USB and I2C, where sensor hubs can
> >>>exists. So instead of constraining the driver to only these two we let it
> >>>to match any HID bus as long as the group is HID_GROUP_SENSOR_HUB.
> >>>
> >>>Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >>>---
> >>> drivers/hid/hid-sensor-hub.c | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>>diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> >>>index 2643bce9..c01f10d 100644
> >>>--- a/drivers/hid/hid-sensor-hub.c
> >>>+++ b/drivers/hid/hid-sensor-hub.c
> >>>@@ -603,7 +603,8 @@ static void sensor_hub_remove(struct hid_device *hdev)
> >>> }
> >>>
> >>> static const struct hid_device_id sensor_hub_devices[] = {
> >>>- { HID_DEVICE(BUS_USB, HID_GROUP_SENSOR_HUB, HID_ANY_ID, HID_ANY_ID) },
> >>>+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> >>>+ HID_ANY_ID) },
> >>> { }
> >>> };
> >>> MODULE_DEVICE_TABLE(hid, sensor_hub_devices);
> >>>
> >>
> >>Hmm, what happens with Bluetooth sensor-hubs? Is the driver now able
> >>to handle them too?
> >
> >It should, yes.
>
> If so, I think patch 1/3 should be modified accordingly.
Do you know if such devices exists currently? If not, I'm not sure if it
makes sense to do that now.
next prev parent reply other threads:[~2013-02-18 11:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 10:31 [PATCH 1/3] HID: extend autodetect to handle I2C sensors as well Mika Westerberg
2013-02-11 10:31 ` [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table Mika Westerberg
2013-02-11 11:21 ` Benjamin Tissoires
2013-02-11 15:53 ` Pandruvada, Srinivas
2013-02-11 17:12 ` Benjamin Tissoires
2013-02-18 9:26 ` Jiri Kosina
2013-02-11 10:31 ` [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus Mika Westerberg
2013-02-11 11:22 ` Benjamin Tissoires
2013-02-18 9:28 ` Jiri Kosina
2013-02-11 15:54 ` Pandruvada, Srinivas
2013-02-12 9:12 ` Mika Westerberg
2013-02-18 11:03 ` Alexander Holler
2013-02-18 11:12 ` Mika Westerberg
2013-02-18 11:22 ` Alexander Holler
2013-02-18 11:33 ` Mika Westerberg [this message]
2013-02-18 11:37 ` Alexander Holler
2013-02-18 11:54 ` Mika Westerberg
2013-02-18 12:13 ` Alexander Holler
2013-02-19 9:22 ` [PATCH] HID: make sensor autodetection independent of underlying bus Mika Westerberg
2013-02-21 10:42 ` Benjamin Tissoires
2013-02-25 12:43 ` Jiri Kosina
2013-02-21 10:34 ` [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus Benjamin Tissoires
2013-02-21 10:52 ` Alexander Holler
2013-02-11 11:20 ` [PATCH 1/3] HID: extend autodetect to handle I2C sensors as well Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218113320.GA2338@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=benjamin.tissoires@gmail.com \
--cc=holler@ahsoftware.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).