From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757593Ab3BRWoM (ORCPT ); Mon, 18 Feb 2013 17:44:12 -0500 Received: from mail.skyhub.de ([78.46.96.112]:36926 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757432Ab3BRWoI (ORCPT ); Mon, 18 Feb 2013 17:44:08 -0500 Date: Mon, 18 Feb 2013 23:44:05 +0100 From: Borislav Petkov To: Greg KH Cc: Mauro Carvalho Chehab , balbi@ti.com, Linux Kernel Mailing List , Steven Rostedt , Frederic Weisbecker , Ingo Molnar , JBottomley@parallels.com, linux-scsi@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, Doug Thompson , linux-edac@vger.kernel.org, rjw@sisk.pl, linux-pm@vger.kernel.org Subject: Re: SYSFS "errors" Message-ID: <20130218224405.GB21493@pd.tnic> Mail-Followup-To: Borislav Petkov , Greg KH , Mauro Carvalho Chehab , balbi@ti.com, Linux Kernel Mailing List , Steven Rostedt , Frederic Weisbecker , Ingo Molnar , JBottomley@parallels.com, linux-scsi@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, Doug Thompson , linux-edac@vger.kernel.org, rjw@sisk.pl, linux-pm@vger.kernel.org References: <20130218171334.GA31329@kroah.com> <20130218172700.GH2663@arwen.pp.htv.fi> <20130218174916.GA2070@kroah.com> <20130218184633.GC10755@arwen.pp.htv.fi> <20130218164638.7cb53baa@redhat.com> <20130218200542.GB20137@arwen.pp.htv.fi> <20130218184742.5a4c3c06@redhat.com> <20130218215434.GB16794@kroah.com> <20130218221306.GA21493@pd.tnic> <20130218222618.GA21818@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130218222618.GA21818@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 18, 2013 at 02:26:18PM -0800, Greg KH wrote: > I don't know, it depends on if userspace can handle this properly or > not. What tools rely on this sysfs file? WHat happens when they get a > non-number in the file? I'm not aware of any, frankly speaking. If there are any, those tools should be able to handle the -ENODEV they get. Now, if this gets changed this way, the read would succeed but they'll have to parse the returned value and see that it is not an integer. So I don't know either. But my gut feeling says to stay concervative and not touch this code - we don't know what uses it and how much we would break by "fixing" it. The current situation is not that big of a deal IMVHO and I'd be willing to accept the small inconcistency versus possibly breaking userspace. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --