From: Borislav Petkov <bp@alien8.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: balbi@ti.com, Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
JBottomley@parallels.com, linux-scsi@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
linux-edac@vger.kernel.org, rjw@sisk.pl,
linux-pm@vger.kernel.org
Subject: Re: SYSFS "errors"
Date: Tue, 19 Feb 2013 12:43:46 +0100 [thread overview]
Message-ID: <20130219114345.GA26623@pd.tnic> (raw)
In-Reply-To: <20130219081149.46972f56@redhat.com>
On Tue, Feb 19, 2013 at 08:11:49AM -0300, Mauro Carvalho Chehab wrote:
> > > I remember I saw some discussions about it in the past at bluesmoke ML,
> > > saying that -ENODEV is the expected behavior when this is not supported.
> > >
> > > Changing from -ENODEV to "N/A" will break anything that would be relying
> > > on the previous behavior. So, I think that such change will for sure break
> > > userspace.
> > >
> > > If we're willing to change it, not creating the "sdram_scrub_rate" sysfs
> > > node is less likely to affect userspace.
This will break scripts which assume this file's presence implicitly.
[ … ]
> @@ -1017,6 +1010,14 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci)
> return err;
> }
>
> + if (mci->set_sdram_scrub_rate && mci->get_sdram_scrub_rate) {
This will break cpc925_edac.c because it defines a
->get_sdram_scrub_rate but not a ->set_sdram_scrub_rate.
I think a maybe better fix would be to figure out the sysfs file
permissions based on the presence of the two functions and *then* add
the attribute.
This way, the only visible change to userspace is the corrected sysfs
file permissions.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-02-19 11:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 15:33 SYSFS "errors" Felipe Balbi
2013-02-18 15:50 ` Greg KH
2013-02-18 15:52 ` Felipe Balbi
2013-02-18 17:13 ` Greg KH
2013-02-18 17:27 ` Felipe Balbi
2013-02-18 17:45 ` Borislav Petkov
2013-02-18 18:47 ` Felipe Balbi
2013-02-18 19:40 ` Borislav Petkov
2013-02-18 20:04 ` Felipe Balbi
2013-02-18 17:49 ` Greg KH
2013-02-18 18:46 ` Felipe Balbi
2013-02-18 19:46 ` Mauro Carvalho Chehab
2013-02-18 20:05 ` Felipe Balbi
2013-02-18 21:47 ` Mauro Carvalho Chehab
2013-02-18 21:54 ` Greg KH
2013-02-18 22:13 ` Borislav Petkov
2013-02-18 22:26 ` Greg KH
2013-02-18 22:44 ` Borislav Petkov
2013-02-19 10:03 ` Mauro Carvalho Chehab
2013-02-19 10:11 ` Felipe Balbi
2013-02-19 11:11 ` Mauro Carvalho Chehab
2013-02-19 11:43 ` Borislav Petkov [this message]
2013-02-19 12:16 ` Mauro Carvalho Chehab
2013-02-19 12:35 ` Borislav Petkov
2013-02-19 12:46 ` Mauro Carvalho Chehab
2013-02-19 13:06 ` Borislav Petkov
2013-02-19 13:15 ` Felipe Balbi
2013-02-19 13:28 ` Borislav Petkov
2013-02-19 13:38 ` Felipe Balbi
2013-02-19 13:50 ` Mauro Carvalho Chehab
2013-02-19 13:55 ` Borislav Petkov
2013-02-19 13:50 ` Borislav Petkov
2013-02-19 13:58 ` Hannes Reinecke
2013-02-19 14:10 ` Borislav Petkov
2013-02-19 14:14 ` Mauro Carvalho Chehab
2013-02-19 14:19 ` Felipe Balbi
2013-02-19 14:35 ` Mauro Carvalho Chehab
2013-02-19 14:50 ` Borislav Petkov
2013-02-19 14:53 ` Felipe Balbi
2013-02-19 13:42 ` Mauro Carvalho Chehab
2013-02-18 21:48 ` Alan Stern
2013-02-18 21:57 ` Felipe Balbi
2013-02-19 7:41 ` Alexander Stein
2013-02-19 10:12 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219114345.GA26623@pd.tnic \
--to=bp@alien8.de \
--cc=JBottomley@parallels.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=dougthompson@xmission.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).