From: Jonas Heinrich <onny@project-insanity.org>
To: "H. Peter Anvin" <hpa@zytor.com>,
len.brown@intel.com, pavel@ucw.cz, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org, rjw@sisk.pl
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [Bisected] 3.7-rc1 can't resume
Date: Sat, 23 Feb 2013 13:18:56 +0000 [thread overview]
Message-ID: <20130223131856.GA682@onny> (raw)
In-Reply-To: <cfd96a3d-5834-4687-b9de-9f044f43b588@email.android.com>
[-- Attachment #1: Type: text/plain, Size: 2539 bytes --]
Hi,
thank you for your replay and the effort you invest in helping me out
with this problem.
Today, I further debuged the problem and reverted this part of your commit
(without understanding the actual code):
diff --git a/arch/x86/realmode/rm/wakeup_asm.S b/arch/x86/realmode/rm/wakeup_asm.S
index 8905166..e56479e 100644
--- a/arch/x86/realmode/rm/wakeup_asm.S
+++ b/arch/x86/realmode/rm/wakeup_asm.S
@@ -110,15 +119,15 @@ ENTRY(wakeup_start)
movl pmode_cr3, %eax
movl %eax, %cr3
- movl pmode_cr4, %ecx
- jecxz 1f
- movl %ecx, %cr4
+ btl $WAKEUP_BEHAVIOR_RESTORE_CR4, %edi
+ jz 1f
+ movl pmode_cr4, %eax
+ movl %eax, %cr4
1:
+ btl $WAKEUP_BEHAVIOR_RESTORE_EFER, %edi
+ jz 1f
movl pmode_efer, %eax
movl pmode_efer + 4, %edx
- movl %eax, %ecx
- orl %edx, %ecx
- jz 1f
movl $MSR_EFER, %ecx
wrmsr
1:
I applied this change to the current 3.8 kernel and it worked!
If you need more test results, just send me patches and I'll try them :)
Best regards,
Jonas
On 02-18 08:21, H. Peter Anvin wrote:
> I might be able to get my hands on a T43 later this week and see if I can reproduce this. This patch seems more plausible, at least... but still puzzling.
>
> Jonas Heinrich <onny@project-insanity.org> wrote:
>
> >On 02-17 21:40, Rafael J. Wysocki wrote:
> >> Does the commit immediately preceding this one behave correctly?
> >Strangely the preceding commit works well, so I bisected the kernel
> >again, this time more carefully and I've got a different result!
> >(see bisect_log attachement).
> >It seems to be commit 73201dbec64aebf6b0dca855b523f437972dc7bb
> >(https://patchwork.kernel.org/patch/1511921/).
> >Someone on LKML already reported an issue with this commit
> >(https://lkml.org/lkml/2012/10/18/228) , but Peter
> >Anvins patch got already applied in newer versions.
> >Reverting this patch with the recent git clone seems to be difficult
> >because it already has too much dependencies.
> >
> >Additionally I've included dmesg dumps of the last good and the bad
> >kernel version.
> >
> >On 02-17 12:52, H. Peter Anvin wrote:
> >> T43 is quite old... which might have exposed unique bugs. How
> >reliable is the failure? Even one misidentified commit results in git
> >bisect giving garbage.
> >It affects really all versions after that commit and the failure
> >happens
> >every time I try to resume my notebook.
> >
> >Best regards,
> >Jonas
>
> --
> Sent from my mobile phone. Please excuse brevity and lack of formatting.
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-02-23 13:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 15:54 [Bisected] 3.7-rc1 can't resume Jonas Heinrich
2013-02-18 16:21 ` H. Peter Anvin
2013-02-23 13:18 ` Jonas Heinrich [this message]
2013-02-23 21:54 ` H. Peter Anvin
[not found] ` <20130320143257.GA473@onny>
2013-05-01 17:01 ` [Bisected] 3.7-rc1 can't resume (still present in 3.9) Jonas Heinrich
2013-05-01 17:33 ` H. Peter Anvin
2013-05-01 18:51 ` Jonas Heinrich
2013-05-01 18:55 ` H. Peter Anvin
2013-05-02 0:45 ` Rafael J. Wysocki
2013-05-02 20:32 ` Jonas Heinrich
2013-05-02 23:29 ` Rafael J. Wysocki
2013-05-03 11:07 ` Jonas Heinrich
2013-05-03 11:37 ` Rafael J. Wysocki
2013-05-28 21:36 ` Rafael J. Wysocki
2013-05-03 12:15 ` Jarkko Sakkinen
2013-07-08 9:50 ` Jonas Heinrich
2013-07-08 13:05 ` Rafael J. Wysocki
2013-07-15 21:11 ` H. Peter Anvin
2013-07-10 20:52 ` Christian Sünkenberg
2013-07-10 23:57 ` H. Peter Anvin
2013-07-12 23:36 ` Christian Sünkenberg
2013-07-12 23:45 ` H. Peter Anvin
2013-07-13 3:21 ` [tip:x86/urgent] x86, suspend: Handle CPUs which fail to #GP on RDMSR tip-bot for H. Peter Anvin
2013-07-15 20:58 ` tip-bot for H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2013-02-17 17:48 [Bisected] 3.7-rc1 can't resume Jonas Heinrich
2013-02-17 20:40 ` Rafael J. Wysocki
2013-02-17 20:52 ` H. Peter Anvin
2012-10-18 12:26 Cédric Godin
2012-10-18 14:17 ` H. Peter Anvin
2012-10-19 7:10 ` Cédric Godin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223131856.GA682@onny \
--to=onny@project-insanity.org \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).