From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
horms@verge.net.au, linus.walleij@linaro.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] gpio: em: Add Device Tree support
Date: Tue, 26 Feb 2013 14:41:06 -0800 [thread overview]
Message-ID: <20130226224106.GC20670@core.coreip.homeip.net> (raw)
In-Reply-To: <20130226132623.18365.36583.sendpatchset@w520>
Hi Magnus,
On Tue, Feb 26, 2013 at 10:26:23PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Update the Emma Mobile GPIO driver to add DT support.
>
...
> @@ -366,15 +387,33 @@ static int em_gio_remove(struct platform
> return 0;
> }
>
#ifdef CONFIG_OF here? No need to have extra aliases in modules if OF
support is not enabled (or is entire ARM arch now enables device tree?).
> +static const struct of_device_id em_gio_dt_ids[] = {
> + { .compatible = "renesas,em-gio", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, em_gio_dt_ids);
> +
> static struct platform_driver em_gio_device_driver = {
> .probe = em_gio_probe,
> .remove = em_gio_remove,
> .driver = {
> .name = "em_gio",
> + .of_match_table = em_gio_dt_ids,
> + .owner = THIS_MODULE,
> }
> };
>
--
Dmitry
next prev parent reply other threads:[~2013-02-26 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 13:26 [PATCH] gpio: em: Add Device Tree support Magnus Damm
2013-02-26 22:41 ` Dmitry Torokhov [this message]
2013-02-27 10:13 ` Magnus Damm
2013-02-28 5:11 ` Simon Horman
2013-03-02 20:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226224106.GC20670@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=horms@verge.net.au \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).