archive mirror
 help / color / mirror / Atom feed
From: Al Viro <>
To: Stephen Rothwell <>
Cc: Mark Jackson <>,,,
	David Woodhouse <>,
	lkml <>
Subject: Re: linux-next: JFFS2 deadlock
Date: Wed, 27 Feb 2013 00:27:55 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 27, 2013 at 10:17:04AM +1100, Stephen Rothwell wrote:
> Hi Mark,
> On Tue, 26 Feb 2013 11:54:56 +0000 Mark Jackson <> wrote:
> >
> > Just tested the current next-20130226 on a custom AM335X board, and I received the JFFS2 deadlock shown below.
> Is this new today?  is it reproducible? Does if ail for Linus' tree?
> Al, could this be something to do with the new stuff in the vfs tree?

Very unlikely.  jffs2_readdir() does, indeed, grab ->sem on the inode in
question and then calls the callback (which might fault, grabbing ->mmap_sem).
Had been doing that all along.  And if the userland area we are doing
getdents(2) into had been mmapped from jffs2 file, jffs2_readpage() would
be called, which would grab ->sem on the inode of file mmaped in there.
Again, that had been going on all along.  Unlike the situation with ->i_mutex,
this one is probably a false positive - ->sem on directories nests outside of
->mmap_sem, ->sem on non-directories - inside.  But that false positive
shouldn't be something new; hell, both paths are present in 2.6.12 with
the lock orders as in the current tree (except that ->sem used to be
a semaphore instead of a mutex).

  reply	other threads:[~2013-02-27  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 11:54 linux-next: JFFS2 deadlock Mark Jackson
2013-02-26 23:17 ` Stephen Rothwell
2013-02-27  0:27   ` Al Viro [this message]
2013-02-27 15:19   ` Mark Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).