From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199Ab3B1CdO (ORCPT ); Wed, 27 Feb 2013 21:33:14 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:58926 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889Ab3B1CdL (ORCPT ); Wed, 27 Feb 2013 21:33:11 -0500 Date: Wed, 27 Feb 2013 18:33:13 -0800 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , Bjorn Helgaas , linux-usb@vger.kernel.org, Tejun Heo , linux-ide@vger.kernel.org, Jeff Garzik , Yinghai Lu Subject: Re: [Resend][PATCH] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type Message-ID: <20130228023313.GC4042@kroah.com> References: <2612891.I2roH54cPk@vostro.rjw.lan> <20130227222032.GA28616@kroah.com> <1723405.gTrRpVTGu2@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1723405.gTrRpVTGu2@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 28, 2013 at 02:11:58AM +0100, Rafael J. Wysocki wrote: > On Wednesday, February 27, 2013 02:20:32 PM Greg Kroah-Hartman wrote: > > On Wed, Feb 27, 2013 at 11:06:52PM +0100, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > After PCI has stopped using the .find_bridge() callback in > > > struct acpi_bus_type, the only remaining users of it are SATA and > > > USB. However, SATA only pretends to be a user, because it points > > > that callback to a stub always returning -ENODEV, and USB uses it > > > incorrectly, because as a result of the way it is used by USB every > > > device in the system that doesn't have a bus type or parent is > > > passed to usb_acpi_find_device() for inspection. > > > > > > What USB actually needs, though, is to call usb_acpi_find_device() > > > for USB ports that don't have a bus type defined, but have > > > usb_port_device_type as their device type. > > > > Ick, that's not good. Can you have the original creator of that code > > (someone else from Intel, I can't remember at the moment), fix that up > > properly and send me patches? > > That won't be necessary afer this patch. Or do you want to fix up USB > separately first? No, sorry, my misunderstanding, I was assuming we still needed to do other USB work after this. If not, that's an even better reason to accept this patch :) thanks, greg k-h