From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Dongsoo Nathaniel Kim <dongsoo.kim@gmail.com>
Subject: Re: [PATCH] perf kvm: fix segfault by initializing file_name to NULL
Date: Thu, 28 Feb 2013 11:24:11 -0300 [thread overview]
Message-ID: <20130228142411.GE2656@ghostprotocols.net> (raw)
In-Reply-To: <512EE073.8090709@gmail.com>
Em Wed, Feb 27, 2013 at 09:43:31PM -0700, David Ahern escreveu:
> On 2/27/13 9:31 PM, Xiao Guangrong wrote:
> >On 02/28/2013 11:29 AM, David Ahern wrote:
> >>Dongsoo reported that perf-kvm was segfaulting. The bug was introduced by
> >>commit 3786063 which moved file_name from struct perf_kvm which was
> >>initialized on the stack to an uninitialized stack variable. Fix by
> >>initializing.
> >>Needs to be applied to 3.7 and 3.8 as well.
> >David, The bug has already been fixed by by Arnaldo, see:
> >http://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=20914ce5b9e1ef4a35f1f09a2c9c8fb8eb1c4d86
> very odd. Arnaldo's latest perf/urgent has the problem -- and no
> initialized variable. Seems to have been dropped somewhere.
Just fast forwarded my perf/urgent to tip/perf/urgent, checked and the
fix is there as pointed out by Xiao.
- Arnaldo
next prev parent reply other threads:[~2013-02-28 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 3:29 [PATCH] perf kvm: fix segfault by initializing file_name to NULL David Ahern
2013-02-28 4:31 ` Xiao Guangrong
2013-02-28 4:43 ` David Ahern
2013-02-28 14:24 ` Arnaldo Carvalho de Melo [this message]
2013-02-28 15:19 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228142411.GE2656@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dongsoo.kim@gmail.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).