From: Andrew Morton <akpm@linux-foundation.org>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sasha Levin <sasha.levin@oracle.com>,
Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>,
Dave Jones <davej@redhat.com>, Hillf Danton <dhillf@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] mempolicy: fix typo
Date: Thu, 28 Feb 2013 15:54:19 -0800 [thread overview]
Message-ID: <20130228155419.cf412612.akpm@linux-foundation.org> (raw)
In-Reply-To: <1362029107-3908-2-git-send-email-kosaki.motohiro@gmail.com>
On Thu, 28 Feb 2013 00:25:07 -0500
kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> Currently, n_new is wrongly initialized. start and end parameter
> are inverted. Let's fix it.
>
> ...
>
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -2390,7 +2390,7 @@ static int shared_policy_replace(struct shared_policy *sp, unsigned long start,
>
> *mpol_new = *n->policy;
> atomic_set(&mpol_new->refcnt, 1);
> - sp_node_init(n_new, n->end, end, mpol_new);
> + sp_node_init(n_new, end, n->end, mpol_new);
> n->end = start;
> sp_insert(sp, n_new);
> n_new = NULL;
huh. What were the runtime effects of this problem?
next prev parent reply other threads:[~2013-02-28 23:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 13:30 mm: BUG in mempolicy's sp_insert Sasha Levin
2013-02-26 1:52 ` KOSAKI Motohiro
2013-02-26 1:54 ` Sasha Levin
2013-02-26 11:39 ` Hillf Danton
2013-02-28 5:25 ` [PATCH 1/2] mempolicy: fix wrong sp_node insertion kosaki.motohiro
2013-02-28 5:25 ` [PATCH 2/2] mempolicy: fix typo kosaki.motohiro
2013-02-28 23:54 ` Andrew Morton [this message]
2013-03-01 1:28 ` KOSAKI Motohiro
2013-02-28 5:26 ` mm: BUG in mempolicy's sp_insert KOSAKI Motohiro
2013-02-28 6:53 ` Hillf Danton
2013-03-01 1:30 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228155419.cf412612.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).