From: Grant Likely <grant.likely@secretlab.ca>
To: Andreas Larsson <andreas@gaisler.com>
Cc: spi-devel-general@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] spi: Initialize cs_gpio and cs_gpios with -ENOENT
Date: Sat, 02 Mar 2013 22:46:47 +0000 [thread overview]
Message-ID: <20130302224647.7D72C3E2F21@localhost> (raw)
In-Reply-To: <1360761625-15562-1-git-send-email-andreas@gaisler.com>
On Wed, 13 Feb 2013 14:20:25 +0100, Andreas Larsson <andreas@gaisler.com> wrote:
> The return value from of_get_named_gpio is -ENOENT when the given index
> matches a hole in the "cs-gpios" property phandle list. However, the
> default value of cs_gpio in struct spi_device and entries of cs_gpios in
> struct spi_master is -EINVAL, which is documented to indicate that a
> GPIO line should not be used for the given spi_device.
>
> This sets the default value of cs_gpio in struct spi_device and entries
> of cs_gpios in struct spi_master to -ENOENT. Thus, -ENOENT is the only
> value used to indicate that no GPIO line should be used.
>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
Applied, thanks.
g.
prev parent reply other threads:[~2013-03-03 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 13:20 [PATCH] spi: Initialize cs_gpio and cs_gpios with -ENOENT Andreas Larsson
2013-03-02 22:46 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302224647.7D72C3E2F21@localhost \
--to=grant.likely@secretlab.ca \
--cc=andreas@gaisler.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=software@gaisler.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).